Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: search latest receipt info first #2629

Merged
merged 2 commits into from
Aug 5, 2024
Merged

fix: search latest receipt info first #2629

merged 2 commits into from
Aug 5, 2024

Conversation

pavelbrm
Copy link
Contributor

@pavelbrm pavelbrm commented Aug 5, 2024

Summary

This PR updates the receipt handling for iOS such that latest_receipt_info is checked before the given receipt. This is because the latter might contain outdated information, the latest has to be consulted with first.

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

@pavelbrm pavelbrm self-assigned this Aug 5, 2024
@pavelbrm pavelbrm requested a review from clD11 August 5, 2024 08:14
clD11
clD11 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@clD11 clD11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pavelbrm pavelbrm merged commit 99480fe into master Aug 5, 2024
12 checks passed
@pavelbrm pavelbrm deleted the handle-ios-initial-purchase-01 branch August 5, 2024 08:53
@pavelbrm pavelbrm mentioned this pull request Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clD11 clD11 clD11 approved these changes

Assignees

@pavelbrm pavelbrm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelbrm @clD11