Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unify use of expiry time #2610

Merged
merged 2 commits into from
Jul 22, 2024
Merged

fix: unify use of expiry time #2610

merged 2 commits into from
Jul 22, 2024

Conversation

pavelbrm
Copy link
Contributor

Summary

This PR improves how expiry time is acquired from the App Store or Play Store data, and cleans up some maintenance code.

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

pavelbrm
pavelbrm commented Jul 19, 2024
View reviewed changes
services/skus/playstore.go
@@ -208,20 +208,6 @@ func (x *playStoreDevNotification) pkg() string {
return x.PackageName
}

func (x *playStoreDevNotification) isBeforeCutoff() bool {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android webhooks have been rolled out, this is no longer needed.

@pavelbrm pavelbrm self-assigned this Jul 19, 2024
@pavelbrm pavelbrm requested a review from clD11 July 19, 2024 09:58
@pavelbrm pavelbrm merged commit 6598d79 into master Jul 22, 2024
12 checks passed
@pavelbrm pavelbrm deleted the use-same-expiry-time branch July 22, 2024 12:25
@pavelbrm pavelbrm mentioned this pull request Jul 22, 2024
Merged
Sneagan pushed a commit that referenced this pull request Jul 23, 2024
@pavelbrm @Sneagan
fix: unify use of expiry time (#2610)
574ad94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clD11 clD11 clD11 approved these changes

Assignees

@pavelbrm pavelbrm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelbrm @clD11