Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: io read timeout on create item creds endpoint #2599

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Conversation

clD11
Copy link
Contributor

@clD11 clD11 commented Jul 16, 2024

Summary

Use io.ReadAll instead of requestutils.ReadJSON and increase the read timeout for grants server.

resolves #2598

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

@clD11 clD11 requested a review from pavelbrm July 16, 2024 15:27
Use io.ReadAll instead of requestutils.ReadJSON and increase the read timeout for grants server.
@clD11 clD11 merged commit 1eda1a0 into master Jul 17, 2024
12 checks passed
@clD11 clD11 deleted the fix-client-timeout branch July 17, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate io read timeout on create item creds endpoint
2 participants