-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set proper expiry time for stripe orders #2589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Approved
368a7a7
to
dec08dd
Compare
[puLL-Merge] - brave-intl/bat-go@2589 DescriptionThis PR refactors the Stripe webhook handling logic in the SKUs service. It introduces a new Possible Issues
Security HotspotsNo significant security vulnerabilities were identified in this change. However, careful review of the webhook signature verification and event parsing logic is always recommended when dealing with external payment processing systems. ChangesChanges
Overall, this PR significantly refactors the Stripe webhook handling logic, making it more modular and easier to maintain. It also improves test coverage for Stripe-related functionality. |
Summary
This PR updates the handling of the Stripe webhooks, improving on how it's done as well as setting the expiry time on orders more accurately.
Main Changes
invoice.updated
webhook is now completely ignored, as it has never had any useful processing;invoice.paid
event plus a leeway (for the case if the next billing cycle's event has been delayed for whatever reason);Type of Change
Tested Environments
Before Requesting Review
Manual Test Plan