Igor/2554/payment dev env #2572
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document the current way of testing during the development and the proposed system. This document will be eventually replaced by the the instructions how to use the new system. Issue #2554
Sync all modules accoross bat-go to use the same package version. This was done using a temporary go.work file (not included into the commit) containing all the modules.
ibukanov
force-pushed
the
igor/2554/payment-dev-env
branch
2 times, most recently
from
6ad71e9
to
e67499b
Compare
ibukanov
force-pushed
the
igor/2554/payment-dev-env
branch
from
de0b2a1
to
39e317a
Compare
ibukanov
force-pushed
the
igor/2554/payment-dev-env
branch
from
76ce948
to
761d1a2
Compare
Updating to the latest AWS SDK to resolve QLDB connectivity issues outside EC2. Synchronizing all modules to use the consistent package version
Move data related to vault unsealing to separated Unsealing struct and decouple the relevant code from Service for simpler testing. This also fixes races when one field is updates when another goroutine reads its value.
ibukanov
force-pushed
the
igor/2554/payment-dev-env
branch
from
761d1a2
to
36e476d
Compare
Query for the table existence rather than relying on error codes from CREATE TABLE. Those are not stable and change between QLDB client versions.
ibukanov
force-pushed
the
igor/2554/payment-dev-env
branch
3 times, most recently
from
095cd74
to
1a97000
Compare
Remove redundant httpsihgnature.NitroVerifier. Instead consistently use nitro.NewVerifier. Fix LookupVerifier signature. The method should return the verifier interface, not a pointer to it. Remove unused or constant arguments from various helper methods for signing and verification. For payment commands read operator key file and PCR2 from environment variables for convenience.
chore: mocking test secretes Pass test secretes using bin-mounted unencrypted file. chore: working worker and own Dockerfile Fix worker not to request TLS when connecting to redis under local testing. Provide own Dockerfile for local development that can also be used to run ipython shell. chore: ipython shell in a Docker container Initial support for running ipython shell as a docker compose service that connects to other services running locally.
ibukanov
force-pushed
the
igor/2554/payment-dev-env
branch
from
1a97000
to
addde59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The present PR is not for merge but for reviewing the proposed dev testing environment.
Type of Change
Tested Environments
Before Requesting Review
Manual Test Plan