Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timestamps to the nitro-shim log output #1887

Closed
wants to merge 1 commit into from
Closed

Add timestamps to the nitro-shim log output #1887

wants to merge 1 commit into from

Conversation

rillian
Copy link

@rillian rillian commented Jul 10, 2023 •
edited
Loading

After launching the enclave application run.sh execs sleep.sh which periodically polls the enclave state and exits if it dies, propagating the failure to the container.

In debugging, it's difficult to match up events in the container log, which are largely the trace output of the run and sleep scripts, so add periodic timestamps to it's clear how long things were running.

Summary

Type of change ( select one )

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before submitting this PR:

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security / privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan:

@rillian
Add timestamps to the nitro-shim log output
8b540b8 
After launching the enclave application `run.sh` execs `sleep.sh`
which periodically polls the enclave state and exits if it dies,
propagating the failure to the container.

In debugging, it's difficult to match up events in the container
log, which are largely the trace output of the run and sleep
scripts, so add periodic timestamps to it's clear how long things
were running.
@rillian
Copy link
Author

rillian commented Jul 10, 2023

ci failures look unrelated

@husobee husobee mentioned this pull request Jul 17, 2023
Merged
18 tasks
@husobee
Copy link
Contributor

husobee commented Jul 17, 2023

new PR created from branch instead of fork so ci doesnt fail:

#1894

@husobee husobee closed this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@husobee husobee husobee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rillian @husobee