Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cust linking xyzabc 3 #1886

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Cust linking xyzabc 3 #1886

merged 4 commits into from
Jul 7, 2023

Conversation

husobee
Copy link
Contributor

@husobee husobee commented Jul 6, 2023

Summary

Type of change ( select one )

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before submitting this PR:

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security / privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan:

@husobee husobee self-assigned this Jul 6, 2023
@husobee husobee requested a review from pavelbrm July 6, 2023 17:57
pavelbrm
pavelbrm previously approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@pavelbrm pavelbrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the fixed test, it looks good to me. 👍

pavelbrm
pavelbrm reviewed Jul 7, 2023
View reviewed changes
services/wallet/datastore.go
@@ -973,7 +973,7 @@ func (pg *Postgres) ConnectCustodialWallet(ctx context.Context, cl *CustodianLin
) values (
$1, $2, $3
)
on conflict (wallet_id, custodian, linking_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My editor is set up to remove trailing spaces, so here and below in this file it did just that.

pavelbrm
pavelbrm approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@pavelbrm pavelbrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a migration to add the new custodian to the database.

@husobee husobee merged commit cd02710 into master Jul 7, 2023
16 checks passed
@husobee husobee deleted the cust-linking-xyzabc-3 branch July 7, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelbrm pavelbrm pavelbrm approved these changes

Assignees

@husobee husobee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@husobee @pavelbrm