Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare External Network in Compose #1880

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Declare External Network in Compose #1880

merged 1 commit into from
Jun 29, 2023

Conversation

pavelbrm
Copy link
Contributor

@pavelbrm pavelbrm commented Jun 29, 2023

Summary

This PR allows the dev and web containers communicate with other services via an external network. No changes to the existing flows.

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before submitting this PR:

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security / privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan:

@pavelbrm pavelbrm self-assigned this Jun 29, 2023
@pavelbrm pavelbrm merged commit f78ecbe into master Jun 29, 2023
@pavelbrm pavelbrm deleted the add-shared-net branch June 29, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants