Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR speeds up the ISO duration parsing by ~200ns (did benchmark the change).
Previously the code would run the regexp twice against the same string - one to determine whether where is a match, and then to get the actual match. Under the hood, both methods use the same low level implementation, and
FindStringSubmatch
is also capable of indicating whether there was a match. Namely, if the result of a call toFindStringSubmatch
was strictlynil
, that means no matches found. Hence the change – match a given string against the pattern only once.This is a follow up to #1865.
Type of Change
Tested Environments
Before Submitting