Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kafka with iam msk #1693

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

kafka with iam msk #1693

wants to merge 2 commits into from

Conversation

husobee
Copy link
Contributor

@husobee husobee commented Nov 7, 2022

Summary

up kafka-go to 0.4.36

Type of change ( select one )

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before submitting this PR:

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security / privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan:

@husobee husobee self-assigned this Nov 7, 2022
hspencer77
hspencer77 previously approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@hspencer77 hspencer77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid. Will assist with https://github.com/brave-intl/bsg-infra/issues/421.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hspencer77 hspencer77 hspencer77 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@husobee @hspencer77