fixed linter (#1065)

brave-intl · Dec 21, 2021 · 5759912 · 5759912
1 parent 48cb24f
commit 5759912
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 10 deletions.
diff --git a/payment/key_test.go b/payment/key_test.go
@@ -71,7 +71,7 @@ func TestGenerateSecret(t *testing.T) {
 	if len(bareSecretKey) != 32 {
 		t.Error("Secret key does not have correct length", err)
 	}
-	if len(k) < 0 {
+	if len(k) <= 0 {
 		t.Error("the key should be bigger than nothing")
 	}
 }

diff --git a/promotion/avro.go b/promotion/avro.go
@@ -42,6 +42,7 @@ const adminAttestationEventSchema = `{
 		{ "name": "created_at", "type": "string" }
 	]}`
 
+// AdminAttestationEvent - kafka admin attestation event
 type AdminAttestationEvent struct {
 	WalletID      string `json:"wallet_id"`
 	Service       string `json:"service"`

diff --git a/promotion/drain.go b/promotion/drain.go
@@ -726,13 +726,13 @@ func (service *Service) MintGrant(ctx context.Context, walletID uuid.UUID, total
 }
 
 // FetchAdminAttestationWalletID - retrieves walletID from topic
-func (s *Service) FetchAdminAttestationWalletID(ctx context.Context) (*uuid.UUID, error) {
-	message, err := s.kafkaAdminAttestationReader.ReadMessage(ctx)
+func (service *Service) FetchAdminAttestationWalletID(ctx context.Context) (*uuid.UUID, error) {
+	message, err := service.kafkaAdminAttestationReader.ReadMessage(ctx)
 	if err != nil {
 		return nil, fmt.Errorf("read message: error reading kafka message %w", err)
 	}
 
-	codec, ok := s.codecs[adminAttestationTopic]
+	codec, ok := service.codecs[adminAttestationTopic]
 	if !ok {
 		return nil, fmt.Errorf("read message: could not find codec %s", adminAttestationTopic)
 	}

diff --git a/promotion/service.go b/promotion/service.go
@@ -98,6 +98,7 @@ func SetAdminAttestationTopic(newTopic string) {
 	adminAttestationTopic = newTopic
 }
 
+// KafkaReader - reader interface
 type KafkaReader interface {
 	ReadMessage(ctx context.Context) (kafka.Message, error)
 }

diff --git a/utils/clients/client.go b/utils/clients/client.go
@@ -270,7 +270,7 @@ func (c *SimpleHTTPClient) do(
 
 	// helpful if you want to read the body as it is
 	bodyBytes, _ := requestutils.Read(resp.Body)
-	resp.Body.Close() // must close
+	_ = resp.Body.Close() // must close
 	resp.Body = ioutil.NopCloser(bytes.NewBuffer(bodyBytes))
 
 	// fmt.Println(req.URL.Host, req.URL.Path, string(bodyBytes))

diff --git a/utils/kafka/dialer.go b/utils/kafka/dialer.go
@@ -14,19 +14,21 @@ import (
 	"time"
 
 	"github.com/linkedin/goavro"
-	kafka "github.com/segmentio/kafka-go"
+	"github.com/segmentio/kafka-go"
 
 	appctx "github.com/brave-intl/bat-go/utils/context"
 	errorutils "github.com/brave-intl/bat-go/utils/errors"
 	"github.com/brave-intl/bat-go/utils/logging"
 )
 
-type KafkaRead struct {
+// Reader - implements KafkaReader
+type Reader struct {
 	kafkaReader *kafka.Reader
 	kafkaDialer *kafka.Dialer
 }
 
-func NewKafkaReader(ctx context.Context, groupID string, topic string) (*KafkaRead, error) {
+// NewKafkaReader - creates a new kafka reader for groupID and topic
+func NewKafkaReader(ctx context.Context, groupID string, topic string) (*Reader, error) {
 	_, logger := logging.SetupLogger(ctx)
 
 	dialer, x509Cert, err := TLSDialer()
@@ -49,13 +51,14 @@ func NewKafkaReader(ctx context.Context, groupID string, topic string) (*KafkaRe
 		Logger:        kafka.LoggerFunc(logger.Printf), // FIXME
 	})
 
-	return &KafkaRead{
+	return &Reader{
 		kafkaReader: kafkaReader,
 		kafkaDialer: dialer,
 	}, nil
 }
 
-func (k *KafkaRead) ReadMessage(ctx context.Context) (kafka.Message, error) {
+// ReadMessage - reads kafka messages
+func (k *Reader) ReadMessage(ctx context.Context) (kafka.Message, error) {
 	return k.kafkaReader.ReadMessage(ctx)
 }