Skip to content

Commit

Permalink
Work around integral bug with --baseline and add future (chapel-l…
Browse files Browse the repository at this point in the history
…ang#24114)

Work around the bug with `type t = integral` with `--baseline`,
described in chapel-lang#24113, and add
a future for it.

This bug causes the test
`library/standard/Types/copyable/copyable-generic` to fail with
`--baseline`, so add a skipif for it.

Follow up to chapel-lang#24058 which
added the test.

[trivial, not reviewed]

Testing:
- [x] paratest
- [x] paratest with `--baseline`
  • Loading branch information
riftEmber authored Dec 20, 2023
2 parents 09dba4d + e1e51b7 commit cdb20db
Show file tree
Hide file tree
Showing 9 changed files with 19 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test/library/standard/Types/copyable/copyable-generic.skipif
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# errors for use of integral type in baseline (bug #24113)
COMPOPTS <= --baseline
1 change: 1 addition & 0 deletions test/types/integral/integral-alias-baseline.bad
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
error: Could not find C type for integral_chpl
4 changes: 4 additions & 0 deletions test/types/integral/integral-alias-baseline.chpl
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
proc main() {
type t = integral;
writeln(t:string);
}
2 changes: 2 additions & 0 deletions test/types/integral/integral-alias-baseline.future
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bug: Compiler error for integral type with --baseline
#24113
1 change: 1 addition & 0 deletions test/types/integral/integral-alias-baseline.good
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
integral
2 changes: 2 additions & 0 deletions test/types/integral/integral-alias-baseline.skipif
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# bug is specific to --baseline
COMPOPTS >= --baseline
4 changes: 4 additions & 0 deletions test/types/integral/integral-alias.chpl
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
proc main() {
type t = integral;
writeln(t:string);
}
1 change: 1 addition & 0 deletions test/types/integral/integral-alias.good
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
integral
2 changes: 2 additions & 0 deletions test/types/integral/integral-alias.skipif
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# errors in --baseline (see integral-alias-baseline.future)
COMPOPTS <= --baseline

0 comments on commit cdb20db

Please sign in to comment.