Skip to content

Commit

Permalink
Fix issues caused by Image module (chapel-lang#25050)
Browse files Browse the repository at this point in the history
Fixes issues caused by merging
chapel-lang#24924 in nightly testing.

This PR also includes an improvement to a skipif for a future, unrelated
to the Image module.

Tested by running a full paratest with/without gasnet

[Reviewed by @DanilaFe]
  • Loading branch information
jabraham17 authored May 15, 2024
2 parents 96e6ff1 + 25e9ce8 commit 592045f
Show file tree
Hide file tree
Showing 21 changed files with 21 additions and 17 deletions.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion test/exercises/c-ray/c-ray.chpl
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
* ----------------------------------------------------------------------------
*/

use Image; // use helper module related to writing out images
use CRayImage; // use helper module related to writing out images
use List;
use IO; // allow use of stderr, stdin, ioMode
import Math.pi;
Expand Down
2 changes: 1 addition & 1 deletion test/exercises/c-ray/old/c-ray.chpl
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
* ----------------------------------------------------------------------------
*/

use Image; // use helper module related to writing out images
use CRayImage; // use helper module related to writing out images
use IO; // allows access to stderr, stdin, ioMode
use List;
use ChplConfig;
Expand Down
2 changes: 1 addition & 1 deletion test/exercises/c-ray/old/c-ray.noreal.good
Original file line number Diff line number Diff line change
@@ -1 +1 @@
../Image.chpl:37: error: pixelType must be an integral type
../CRayImage.chpl:37: error: pixelType must be an integral type
2 changes: 1 addition & 1 deletion test/exercises/c-ray/old/c-ray.toosmall.good
Original file line number Diff line number Diff line change
@@ -1 +1 @@
../Image.chpl:33: error: pixelType 'int(8)' isn't big enough to store 8 bits per color
../CRayImage.chpl:33: error: pixelType 'int(8)' isn't big enough to store 8 bits per color
2 changes: 1 addition & 1 deletion test/exercises/c-ray/solutions/c-ray-1.chpl
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
* ----------------------------------------------------------------------------
*/

use Image; // use helper module related to writing out images
use CRayImage; // use helper module related to writing out images
use List;
use IO; // allow use of stderr, stdin, ioMode
import Math.pi;
Expand Down
2 changes: 1 addition & 1 deletion test/exercises/c-ray/solutions/c-ray-1a.chpl
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
* ----------------------------------------------------------------------------
*/

use Image; // use helper module related to writing out images
use CRayImage; // use helper module related to writing out images
use List;
use IO; // allow use of stderr, stdin, ioMode
import Math.pi;
Expand Down
2 changes: 1 addition & 1 deletion test/exercises/c-ray/solutions/c-ray-2.chpl
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
* ----------------------------------------------------------------------------
*/

use Image; // use helper module related to writing out images
use CRayImage; // use helper module related to writing out images
use List;
use IO; // allow use of stderr, stdin, ioMode
import Math.pi;
Expand Down
2 changes: 1 addition & 1 deletion test/exercises/c-ray/solutions/c-ray-2a.chpl
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
* ----------------------------------------------------------------------------
*/

use Image; // use helper module related to writing out images
use CRayImage; // use helper module related to writing out images
use List;
use IO; // allow use of stderr, stdin, ioMode
import Math.pi;
Expand Down
2 changes: 1 addition & 1 deletion test/exercises/c-ray/solutions/c-ray-3.chpl
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
* ----------------------------------------------------------------------------
*/

use Image; // use helper module related to writing out images
use CRayImage; // use helper module related to writing out images
use List;
use IO; // allow use of stderr, stdin, ioMode
import Math.pi;
Expand Down
2 changes: 1 addition & 1 deletion test/exercises/c-ray/solutions/c-ray-3a.chpl
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
* ----------------------------------------------------------------------------
*/

use Image; // use helper module related to writing out images
use CRayImage; // use helper module related to writing out images
use List;
use IO; // allow use of stderr, stdin, ioMode
import Math.pi;
Expand Down
2 changes: 1 addition & 1 deletion test/exercises/c-ray/solutions/c-ray-4.chpl
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
* ----------------------------------------------------------------------------
*/

use Image; // use helper module related to writing out images
use CRayImage; // use helper module related to writing out images
use List;
use IO; // allow use of stderr, stdin, ioMode
import Math.pi;
Expand Down
2 changes: 1 addition & 1 deletion test/exercises/c-ray/solutions/c-ray-4a.chpl
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
* ----------------------------------------------------------------------------
*/

use Image; // use helper module related to writing out images
use CRayImage; // use helper module related to writing out images
use List;
use IO; // allow use of stderr, stdin, ioMode
import Math.pi;
Expand Down
2 changes: 1 addition & 1 deletion test/exercises/c-ray/solutions/c-ray-5.chpl
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
* ----------------------------------------------------------------------------
*/

use Image; // use helper module related to writing out images
use CRayImage; // use helper module related to writing out images
use List;
use IO; // allow use of stderr, stdin, ioMode
import Math.pi;
Expand Down
2 changes: 1 addition & 1 deletion test/exercises/c-ray/solutions/c-ray-6.chpl
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
* ----------------------------------------------------------------------------
*/

use Image; // use helper module related to writing out images
use CRayImage; // use helper module related to writing out images
use List;
use IO; // allow use of stderr, stdin, ioMode
import Math.pi;
Expand Down
2 changes: 1 addition & 1 deletion test/exercises/c-ray/solutions/c-ray-7.chpl
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
* ----------------------------------------------------------------------------
*/

use Image; // use helper module related to writing out images
use CRayImage; // use helper module related to writing out images
use List;
use IO; // allow use of stderr, stdin, ioMode
import Math.pi;
Expand Down
2 changes: 1 addition & 1 deletion test/exercises/c-ray/solutions/c-ray-8.chpl
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
* ----------------------------------------------------------------------------
*/

use Image; // use helper module related to writing out images
use CRayImage; // use helper module related to writing out images
use List;
use IO; // allow use of stderr, stdin, ioMode
import Math.pi;
Expand Down
2 changes: 2 additions & 0 deletions test/functions/generic/type-func-return-generic.future
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
bug: type functions should not segfault when return generic types
#25039

When resolving this future, remove the skipif
2 changes: 2 additions & 0 deletions test/functions/generic/type-func-return-generic.skipif
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# this works fine on linux64
CHPL_TARGET_PLATFORM==linux64
2 changes: 1 addition & 1 deletion test/library/packages/Image/smallMovie.skipif
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

if [ ! command -v ffmpeg &> /dev/null ]; then
if ! command -v ffmpeg &> /dev/null; then
echo True;
else
echo False;
Expand Down

0 comments on commit 592045f

Please sign in to comment.