Introduce changes from master to sig-auth-acceptance branch #300

ibihim · 2024-06-28T14:23:28Z

What

Version bump sig-auth-acceptance branch.
Introduce important changes from master to sig-auth-acceptance branch.
Make e2e-tests work on arm64 machines.

Why

For some of the change request a newer version of k8s is required, like the wrapper around token audiences.
The http/2 disablement is important from master for one of the change requests.
Reduce differences in the Makefile to have a smaller context change.
Enable e2e tests on ARM64, in particular for MacOS M-Chip users.

.github/workflows/build.yml

README.md

liouk · 2024-07-02T14:22:40Z

/lgtm

stlaz

much smaller change than I thought it would be 👍

cmd/kube-rbac-proxy/app/kube-rbac-proxy.go

stlaz · 2024-07-10T19:21:53Z

pkg/authn/oidc.go

-		IssuerURL:            config.IssuerURL,
-		ClientID:             config.ClientID,
+	tokenAuthenticator, err := oidc.New(ctx, oidc.Options{
+		JWTAuthenticator: apiserver.JWTAuthenticator{


can we remove the old options and just wire the new config, since we have the chance?

@stlaz, WDYT?

a610979

Not quite what I had in mind. Keeping the legacy struct for legacy options is fine, and I think preferable.

Perhaps this is not for this PR (I'd rather we removed a610979) but why don't we try to move https://github.com/kubernetes/kubernetes/blob/04434b7bf4f8afe258fed430f163102abe1a24d5/pkg/kubeapiserver/options/authentication.go#L719-L787 somewhere where we could import it - it's how most of the other functionality in that file is implemented and this TODO mentions that it might be preferable here, too.

I understand. Let me remove the change.

Introducing the suggested change, is definitely another PR.

would you create a k/k issue and link it to this PR, please?

What do you expect me to create an issue for? That we finally need to move that into one place instead of copying it across different places and that this PR is an example of why we need it?

cmd/kube-rbac-proxy/app/options/proxyoptions.go

stlaz · 2024-09-10T11:15:58Z

pkg/authn/identityheaders/identityheaders_test.go

+			name: "should pass through",
+			cfg:  &identityheaders.AuthnHeaderConfig{},
+			req: func() *http.Request {
+				req, err := http.NewRequest(http.MethodGet, "http://example.com", nil)


Add a set of chaining functions that construct a request as necessary

edit: does not have to be chaining

I don't quite understand the benefit.

removal of duplicated code + it's easier to write future unit tests

pkg/authn/identityheaders/identityheaders.go

stlaz · 2024-09-11T08:17:59Z

please squash the last two changes to where the code was originally introduced and let's merge this PR

ibihim requested a review from stlaz June 28, 2024 14:23

ibihim force-pushed the sig-auth-acceptance-bump branch 4 times, most recently from f1f64b6 to ee29cc5 Compare June 28, 2024 14:40

ibihim added 2 commits June 28, 2024 16:41

go.*: bump deps

b438fe7

c/k/app,p/authn,test/e2e/oidc: fix oidc after bump

ad75c81

ibihim force-pushed the sig-auth-acceptance-bump branch 6 times, most recently from 7c1476a to 5c0c8bc Compare July 2, 2024 09:32

liouk suggested changes Jul 2, 2024

View reviewed changes

.github/workflows/build.yml Outdated Show resolved Hide resolved

README.md Show resolved Hide resolved

ibihim force-pushed the sig-auth-acceptance-bump branch from 5c0c8bc to 96e75e7 Compare July 2, 2024 13:30

ibihim added 3 commits July 2, 2024 15:32

c/k/a/options: add oidc-username-prefix

c598642

c/k/a/opts: add format to info log

7382c08

examples,scripts,test: removed deprecated flags

7aaa847

ibihim force-pushed the sig-auth-acceptance-bump branch from 96e75e7 to c7e1aff Compare July 2, 2024 13:33

stlaz reviewed Jul 10, 2024

View reviewed changes

ibihim force-pushed the sig-auth-acceptance-bump branch 3 times, most recently from f356040 to a610979 Compare July 24, 2024 11:55

ibihim requested a review from stlaz July 24, 2024 11:56

ibihim force-pushed the sig-auth-acceptance-bump branch from a610979 to 0b4a724 Compare July 25, 2024 09:23

stlaz assigned stlaz and unassigned stlaz Jul 29, 2024

ibihim force-pushed the sig-auth-acceptance-bump branch from 0b4a724 to c7e1aff Compare September 4, 2024 08:38

stlaz reviewed Sep 10, 2024

View reviewed changes

ibihim added 5 commits September 11, 2024 10:31

c/k/app: add the ability to disable http/2

4a0e649

Makefile: make e2e work for arm64

774de70

Makefile: Introdocue Makefile from master

95d49dc

pkg/{authn,authz}: rm consumed headers, add FIXME for rest

797e950

pkg/authz/rewrite: fix linter issue

027349e

ibihim force-pushed the sig-auth-acceptance-bump branch from e42f4f4 to 027349e Compare September 11, 2024 08:31

ibihim merged commit 155cd10 into brancz:sig-auth-acceptance Sep 11, 2024
7 checks passed

ibihim deleted the sig-auth-acceptance-bump branch September 11, 2024 09:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce changes from master to sig-auth-acceptance branch #300

Introduce changes from master to sig-auth-acceptance branch #300

ibihim commented Jun 28, 2024

liouk commented Jul 2, 2024

stlaz left a comment

stlaz Jul 10, 2024

ibihim Jul 24, 2024

stlaz Jul 29, 2024

ibihim Sep 4, 2024

stlaz Sep 4, 2024

ibihim Sep 10, 2024

stlaz Sep 10, 2024 •

edited

Loading

ibihim Sep 10, 2024

stlaz Sep 11, 2024

stlaz commented Sep 11, 2024

Introduce changes from master to sig-auth-acceptance branch #300

Introduce changes from master to sig-auth-acceptance branch #300

Conversation

ibihim commented Jun 28, 2024

What

Why

liouk commented Jul 2, 2024

stlaz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stlaz Sep 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stlaz commented Sep 11, 2024

stlaz Sep 10, 2024 •

edited

Loading