Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LIVARNO home Tischleuchte (Lidl 14158804L) #2585

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

RubenKelevra
Copy link
Contributor

Device information

https://www.lidl.de/p/livarno-home-tischleuchte-zigbee-smart-home/p100342011

Home Assistant Device information

Livarno Home LED desk lamp RGBW (14158804L)
by Lidl

Reports as different device via Zigbee:

Zigbee Model: TS0505B
Zigbee Manufacturer: _TZ3210_hxtfthp5

Checklist

  • I have created a single PR per device. When you have multiple submissions please create separate PR's.
  • For lights - I have only included the gzipped files (*.gz), not the raw CSV files.
  • For lights - I have provided a CSV file per supported color mode. Look that up in Developer Tools -> States

Additional info

Copy link
Contributor

github-actions bot commented Oct 14, 2024

Thank you for submitting light measurements!
Here are some visualizations for the CSV files.

Image
Image

@RubenKelevra
Copy link
Contributor Author

I couldn't generate the graphs, because python 3.12 isn't supported yet. But looking at the first graph it looks a bit weird. 🤔

@RubenKelevra
Copy link
Contributor Author

Ah and the very first line of measurements for White balance is missing, because the lamp will turn on, but flip off again, immediately, thus I deleted this value as the lamp can't be used at this setting.

@RubenKelevra
Copy link
Contributor Author

Looks like the bot here is not happy with the formatting the measure script outputs? 🤔

@bramstroker
Copy link
Owner

Looks like the bot here is not happy with the formatting the measure script outputs? 🤔

Unsure, I don't see any issues with model.json. seems everything is fine. Let's see after merge.

@bramstroker
Copy link
Owner

I couldn't generate the graphs, because python 3.12 isn't supported yet. But looking at the first graph it looks a bit weird. 🤔

What seems weird in the graph?

@RubenKelevra
Copy link
Contributor Author

I couldn't generate the graphs, because python 3.12 isn't supported yet. But looking at the first graph it looks a bit weird. 🤔

What seems weird in the graph?

Well, the step in there around 50.

But I've looked over the data, looks fine to me. It's just that it's a bit condensed in the graph.

@RubenKelevra
Copy link
Contributor Author

RubenKelevra commented Oct 15, 2024

Looks like the bot here is not happy with the formatting the measure script outputs? 🤔

Unsure, I don't see any issues with model.json. seems everything is fine. Let's see after merge.

Well, the bot made a commit and removed some white spaces (9bde7c1). I've reverted it and forbid the bot to edit 🥲

@bramstroker
Copy link
Owner

Looks like the bot here is not happy with the formatting the measure script outputs? 🤔

Unsure, I don't see any issues with model.json. seems everything is fine. Let's see after merge.

Well, the bot made a commit and removed some white spaces (9bde7c1). I've reverted it and forbid the bot to edit 🥲

That's the setting for JSON formatting in the model.json in pre commit hook, so it's consistent for all files. I will change the measure script so it has the same output to prevent reformatting every time.

@RubenKelevra
Copy link
Contributor Author

Looks like the bot here is not happy with the formatting the measure script outputs? 🤔

Unsure, I don't see any issues with model.json. seems everything is fine. Let's see after merge.

Well, the bot made a commit and removed some white spaces (9bde7c1). I've reverted it and forbid the bot to edit 🥲

That's the setting for JSON formatting in the model.json in pre commit hook, so it's consistent for all files. I will change the measure script so it has the same output to prevent reformatting every time.

Thanks :)

@bramstroker bramstroker merged commit 7003ba2 into bramstroker:master Oct 16, 2024
9 of 10 checks passed
@bramstroker
Copy link
Owner

Looks like the bot here is not happy with the formatting the measure script outputs? 🤔

Unsure, I don't see any issues with model.json. seems everything is fine. Let's see after merge.

Well, the bot made a commit and removed some white spaces (9bde7c1). I've reverted it and forbid the bot to edit 🥲

That's the setting for JSON formatting in the model.json in pre commit hook, so it's consistent for all files. I will change the measure script so it has the same output to prevent reformatting every time.

Thanks :)

Fixed with #2597

@RubenKelevra RubenKelevra deleted the add_livarno_14158804L branch October 18, 2024 07:41
@RubenKelevra RubenKelevra mentioned this pull request Oct 18, 2024
3 tasks
@RubenKelevra
Copy link
Contributor Author

@bramstroker I think you missed the Lidl 14158804L in the changelog for beta 3 :)

@bramstroker
Copy link
Owner

Will be added in the changelog of 1.15.0 stable.

Btw the profiles will be available right away at https://library.powercalc.nl/ after MR is merged. And ready for download / discovery after you restart HA.
There is no need to wait for new powercalc versions anymore.

@RubenKelevra
Copy link
Contributor Author

RubenKelevra commented Oct 20, 2024

Ah, very cool! Didn't know that!

Yeah I was just updating the version to the beta and got the new profile on my restart shown up. That's why I thought it is in the beta 3 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants