Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add power measure data for Yeelight YLDP02YL and Osram PAR16 #1828

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Add power measure data for Yeelight YLDP02YL and Osram PAR16 #1828

merged 2 commits into from
Aug 17, 2023

Conversation

hekm77
Copy link
Contributor

@hekm77 hekm77 commented Aug 17, 2023 •
edited
Loading

Add Yeelight RGBW E27 Smart LED Bulb (YLDP02YL)
Add Osram LIGHTIFY 6W GU10 (PAR16 50 TW)

@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@hekm77 hekm77 changed the title Add Yeelight RGBW E27 Smart LED Bulb (YLDP02YL) Add power measure data for yeelight and osram Aug 17, 2023
@bramstroker
Copy link
Owner

Nice job! looks good to me.
Next time it's preferable to have separate PR per light. You can create a separate branch to create separate PR's.
Then it will also be mentioned as a separate entry in the release notes.

@bramstroker bramstroker changed the title Add power measure data for yeelight and osram Add power measure data for Yeelight YLDP02YL and Osram PAR16 Aug 17, 2023
@bramstroker bramstroker merged commit 3416508 into bramstroker:master Aug 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hekm77 @bramstroker