Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added similar bulb model LWA021 as alias #1819

Closed
wants to merge 1 commit into from

Conversation

Wendelstein7
Copy link

LWA021 is a presumed similar filament bulb, with (near) identical power consumption. Only difference is that LWA021 has "Thin Filament" written on the box.

LWA021 is a presumed similar filament bulb, with (near) identical power consumption. Only difference is that LWA021 has "Thin Filament" written on the box.
@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bramstroker
Copy link
Owner

How can we be sure that this has exactly the same power consumption? Are you able to take some samples and compare?
"Quite comparable" is not enough to add is as an alias as the quality and correctness of the library is very important.

Anyway you can always add to your system and force LWO001 for your light by following the procedure explained here: https://homeassistant-powercalc.readthedocs.io/en/latest/sensor-types/virtual-power-library.html

@Wendelstein7
Copy link
Author

Thanks for your feedback! I indeed have not taken exact measures as my equipment is not precise enough (lowest measure is 0.5 W) I fully understand (and support) not merging any PR's based on being 'quite comparable'. With this insight I don't think this PR should be merged, and in the meantime I have used the specified light on my own system. Thanks for your information and thanks for your work on this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants