[v7] Update BTThreeDSecureRequest Parameters

[agedd]

Summary of changes

• Update BTThreeDSecureRequest properties to have everything in the init vs using dot syntax
• Update related unit tests
• Confirmed with the gateway on questions around required vs optional parameters

Checklist

• Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

• @agedd

[warmkesselj]

One comment but it's not a blocker. Approving ahead of time.

[jaxdesmarais]

Based on this logic it looks like both amount and the delegate may be required:

braintree_ios/Sources/BraintreeThreeDSecure/BTThreeDSecureClient.swift

Lines 62 to 74 in 5ecb18d

	if request.amount?.decimalValue.isNaN == true || request.amount == nil {
	NSLog("%@ BTThreeDSecureRequest amount can not be nil or NaN.", BTLogLevelDescription.string(for: .critical))
	let error = BTThreeDSecureError.configuration("BTThreeDSecureRequest amount can not be nil or NaN.")
	notifyFailure(with: error, completion: completion)
	return
	}
	if request.threeDSecureRequestDelegate == nil {
	let message = "Configuration Error: threeDSecureRequestDelegate can not be nil when versionRequested is 2."
	let error = BTThreeDSecureError.configuration(message)
	notifyFailure(with: error, completion: completion)
	return
	}

[agedd]

ahh yep, good catch! the amount does seem to be required (i've also confirmed this by raising a BT 3D Secure General Inquiry workflow request) - as for the delegate, it seems that it was also previously optional so i wonder if it's okay to leave that as is 👀

[jaxdesmarais]

nit: we can probably just leave this out of the init for now then remove it in the ticket to remove the property completely. If that's more work than it's worth though, feel free to leave and we can hopefully pick up that cleanup ticket soon!

[jaxdesmarais]

🤔 I am getting an error with the amount as a string in the demo app. Are we sure this is valid? It looks like a Double works as expected.

[agedd]

hmm yea i'm a bit confused on this - i also feel amount as Double makes more sense (and this aligns with what is mentioned in our iOS BT Dev Docs) but after asking here #bt-service-3dsecure and checking the android equivalent it looks like they define amount as a string