Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V7] Make BTClientToken internal + drop Obj-C exposure #1445

Merged
merged 2 commits into from
Oct 28, 2024
Merged

[V7] Make BTClientToken internal + drop Obj-C exposure #1445

merged 2 commits into from
Oct 28, 2024

Conversation

scannillo
Copy link
Contributor

@scannillo scannillo commented Oct 23, 2024 •
edited
Loading

DTMOBILES-1137

Summary of changes

  • Drop Objective-C support for BTClientToken
    • It was only exposed to Objective-C for our DropIn SDK to use, not for merchant use.
    • The DropIn has not been compatible with the BT iOS SDK since it was re-written in Swift (v6). The decision was made to remove the Obj-C exposure that still exists for Drop-In since we have no current plan of updating it, and if we do it will likely require a re-write.
  • Make BTClientToken internal
  • Remove unused protocol conformances & related unit tests

Checklist

  • Added a changelog entry

Authors

@scannillo

@scannillo scannillo marked this pull request as ready for review October 23, 2024 19:49
@scannillo scannillo requested a review from a team as a code owner October 23, 2024 19:49
@scannillo scannillo changed the title Make BTClientToken internal + drop Obj-C exposure [V7] Make BTClientToken internal + drop Obj-C exposure Oct 23, 2024
jaxdesmarais
jaxdesmarais approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@scannillo scannillo merged commit 857fbc9 into v7 Oct 28, 2024
8 checks passed
@scannillo scannillo deleted the cleanup-client-token-access branch October 28, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warmkesselj warmkesselj warmkesselj approved these changes

@agedd agedd agedd approved these changes

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scannillo @jaxdesmarais @agedd @warmkesselj