Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert BraintreeDemoCardTokenizationViewController to Swift #1095

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Convert BraintreeDemoCardTokenizationViewController to Swift #1095

merged 3 commits into from
Aug 29, 2023

Conversation

jaxdesmarais
Copy link
Contributor

Summary of changes

  • Convert BraintreeDemoCardTokenizationViewController to Swift

Checklist

  • [ ] Added a changelog entry

Authors

@jaxdesmarais jaxdesmarais requested a review from a team as a code owner August 25, 2023 20:15
scannillo
scannillo reviewed Aug 28, 2023
View reviewed changes
...lication/Features/Credit Card Tokenization/BraintreeDemoCardTokenizationViewController.swift Outdated
Comment on lines 6 to 7
let cardFormView = BTCardFormView()
let autofillButton = UIButton(type: .system)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit - private

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: 7d02e20

@jaxdesmarais jaxdesmarais merged commit 25774f4 into main Aug 29, 2023
6 checks passed
@jaxdesmarais jaxdesmarais deleted the convert-card-viewcontroller branch August 29, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshropshire sshropshire sshropshire approved these changes

@scannillo scannillo scannillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaxdesmarais @scannillo @sshropshire