Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New SelectMenu component #2665

Merged
merged 160 commits into from
Mar 21, 2023
Merged

New SelectMenu component #2665

merged 160 commits into from
Mar 21, 2023

Conversation

domidomi
Copy link
Contributor

@domidomi domidomi commented Jan 30, 2023 •
edited
Loading

New SelectMenu component.
Improvements ideas for v2:

Screenshot 2023-03-09 at 10 57 42

domidomi and others added 30 commits January 23, 2023 12:52
@domidomi
Component draft
194a848
@domidomi
Add @floating-ui/react
47fbcbe
@domidomi
Use combobox and listbox role html elements to render selected value …
6f456ca 
…and options. Handle option click. Add story with value change
@domidomi
Allow expanding and collapsing options list
0e67c5c
@domidomi
Use floating-ui wrapper for options list
23dd595
@domidomi
Import Select scss file
83064fb
@domidomi
Handle expanded state and option change on controlled and uncontrolle…
90f167b 
…d component
@domidomi
Create useSelect hook
f1cb79d
@domidomi
Add placeholder
b474b1c
@domidomi
Handle defaultExpanded
540701c
@domidomi
Create useFloatingSelect hook
7cbf391
@domidomi
Add listeners that dismiss (close) the floating element
d4ca7f6
@domidomi
Merge branch 'master' into new-select-component
0126289
@domidomi
Display subject icons
ee51511
@domidomi
Add multiple options select
2d49e78
@domidomi
Remove expanded controlled story, as clicking outside of select close…
f6307bf 
…s it automatically. Rename isControlled to isExpandedControlled
@domidomi
Remove option groups support
cd4c403
@domidomi
Create SelectOption component. Use useListNavigation
255228d
@domidomi
Layout improvements
1234084
@domidomi
Display caret up on the select when expanded
a8d792f
@domidomi
Style select element, add story with long label, add support for full…
769e53f 
… width select
@domidomi
Add spacing between icon and label in the select element
a65dd9e
@domidomi
Adjust popup position when no space available
2db23a9
@domidomi
Add fallback placement for the popup position
7498ea5
@domidomi
Add popup offset
c9f5799
@domidomi
Make select popup scroll when not enough space
42b0684
@domidomi
Fix border radius on the select popup
2639200
@domidomi
Add more items to the story
e89af31
@domidomi
Remove unused import
bf36118
@domidomi
Handle size change, move select display value declaration to the Sele…
f658c56 
…ct component
coderitual
coderitual reviewed Mar 17, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
coderitual
coderitual approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@coderitual coderitual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All points were discussed and are non blocking

@clxandstuff clxandstuff mentioned this pull request Mar 20, 2023
Closed
@domidomi domidomi merged commit 02e0063 into master Mar 21, 2023
@domidomi domidomi deleted the new-select-component branch March 21, 2023 08:24
@clxandstuff clxandstuff mentioned this pull request Mar 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderitual coderitual coderitual approved these changes

@clxandstuff clxandstuff clxandstuff approved these changes

@katarzynatobis katarzynatobis Awaiting requested review from katarzynatobis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@domidomi @coderitual @clxandstuff @katarzynatobis