docs: merged coding_style_standards.md with #820 #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jakub 'Eremiell' Marek <[email protected]>
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
What's the purpose of this PR? these changes are the same as in #820 |
The current coding style standards have a slight issue with them (contradicting itself). Rather than just pushing a fix for that, I thought it would be ideal to just drag over the change in #820 into here as that already has the fix but also expands upon a couple sections. |
Commandserver
approved these changes
Sep 10, 2023
|
Requested Review again from you @Commandserver as I've made another change, adding a new section. Don't want you to miss it in-case you don't like something about it. |
Mishura4
reviewed
Sep 10, 2023
Mishura4
pushed a commit
to Mishura4/DPP-PRs
that referenced
this pull request
Sep 17, 2023
…oxdotcc#852) Co-authored-by: Jakub 'Eremiell' Marek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges
coding_style_standards.mdwith #820. This is because, previously, the coding standards were slightly incorrect and needed fixing (as requested by Brain).devbranch.