Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add /bigobj to non-VCPKG MSVC CMake flags, fixing ninja build, and fix CMakeSettings.json #740

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

Mishura4
Copy link
Member

@Mishura4 Mishura4 commented Jul 20, 2023

  • Adds /bigobj to Debug MSVC CMake flags for building the library, required to use nlohmann::json with Ninja (see Compile error in VS2015 when compiling unit-conversions.cpp nlohmann/json#1114) (in library/CMakeLists.txt so it shouldn't affect vcpkg)
  • Fixes the "x64-Debug" profile to actually build in Debug instead of currently Release
  • Adds "x64-Release", "x64-Debug-Coro", "x64-Release-Coro" CMake profiles to use with Visual Studio

@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit ce56d13
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/64b931e5a430280008e736f2
😎 Deploy Preview https://deploy-preview-740--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mishura4 Mishura4 changed the title fix: add /bigobj to MSVC CMake flags, fixing ninja build, and fix CMakeSettings.json fix: add /bigobj to Non-VCPKG MSVC CMake flags, fixing ninja build, and fix CMakeSettings.json Jul 20, 2023
@Mishura4 Mishura4 changed the title fix: add /bigobj to Non-VCPKG MSVC CMake flags, fixing ninja build, and fix CMakeSettings.json fix: add /bigobj to non-VCPKG MSVC CMake flags, fixing ninja build, and fix CMakeSettings.json Jul 20, 2023
@braindigitalis
Copy link
Contributor

we don't support vs2015 though

@Mishura4
Copy link
Member Author

It's an error that happens since vs2015, it still happens on recent versions with Ninja

@braindigitalis braindigitalis merged commit b3cd632 into brainboxdotcc:dev Jul 24, 2023
24 checks passed
@Mishura4 Mishura4 deleted the msvc_ninja_fix branch August 8, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants