feat(coro): coro 2.0 #1188
Closed
feat(coro): coro 2.0 #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
documentation
|
This is huge, god damn. I'll pull this branch locally and test this with my bot, will give you a shout on Discord if I have any issues! |
|
lgtm, will test it out when its in dev as the coro features in my bot arent complete so i can't test this thoroughly. |
Mishura4
commented
Jul 11, 2024
| * @attention This will BLOCK THE THREAD. It is likely you want to use co_await instead. | ||
| * @param duration Maximum duration to wait for | ||
| * @retval If T is void, returns a boolean for which true means the awaitable completed, false means it timed out. | ||
| * @retval If T is non-void, returns a std::optional<T> for which an absense of value means timed out. |
There was a problem hiding this comment.
note to self: fix "absence"
Mishura4
commented
Jul 11, 2024
| return static_cast<const detail::task::task_base<R>&>(*this); | ||
| ~task() { | ||
| if (handle && this->valid()) { | ||
| if (this->abandon() & state_flags::sf_done) { |
There was a problem hiding this comment.
note to self: don't use an implicit conversion to bool
|
Closing to reopen from https://github.com/brainboxdotcc/DPP/tree/coro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a massive PR that fundamentally changes the coro implementation, everything is a derivative of dpp::awaitable and dpp::promise now. This helps with de-duplicating a lot of coro-related code, making it easier to maintain, and offers a way to add things to all of the coroutine types at once, for example the
sync_waitmethod available on all awaitable types, which can help for example with starting a coroutine from a non-coroutine.Still missing some documentation & polishing
Code change checklist