Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Multiplicity{M} type #199

Merged
merged 15 commits into from
Nov 16, 2023
Merged

New Multiplicity{M} type #199

merged 15 commits into from
Nov 16, 2023

Conversation

brainandforce
Copy link
Owner

This type should facilitate indexing of some new data types by spin state. SpinRange{M} has a single type parameter, the multiplicity M, which is an Int, and it behaves like UnitRange(-(M-1)//2, (M-1)//2), where all elements are valid angular momenta for that multiplicity.

I am willing to go back and rename this type to Multiplicity or something else, because even though SpinRange is an AbstractUnitRange, the type parameter M is the spin multiplicity.

@brainandforce brainandforce force-pushed the features/spin-range branch 3 times, most recently from 45bf593 to 3457e77 Compare November 16, 2023 17:31
@brainandforce
Copy link
Owner Author

I decided to rename the type to Multiplicity{M} and rebased it on main to add the test fixes from the previously merged PR.

@brainandforce brainandforce changed the title New SpinRange{M} type New Multiplicity{M} type Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1311875) 59.77% compared to head (b535f66) 58.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
- Coverage   59.77%   58.69%   -1.09%     
==========================================
  Files          20       21       +1     
  Lines        1432     1346      -86     
==========================================
- Hits          856      790      -66     
+ Misses        576      556      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brainandforce brainandforce merged commit 5a17160 into main Nov 16, 2023
5 checks passed
@brainandforce brainandforce deleted the features/spin-range branch November 16, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant