New Electrum.dimension internal function and upgrades to Electrum.DataSpace methods
#189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Electrum.dimensionfunction returns the dimension parameter associated with aDataSpaceobject. For now, this assumes that the type parameter is an integer, but in the future we may want to handle things like metric tensors which provide some notion of a number of dimensions, but are not integers themselves.Electrum.DataSpacenow has a new fallback when a type is given instead of an object:Therefore, by default, a new type with a
basisfield will automatically infer from the field's type. This can be overridden if needed for specific types.