Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/documentation builds #186

Merged
merged 20 commits into from
Oct 18, 2023
Merged

Fix/documentation builds #186

merged 20 commits into from
Oct 18, 2023

Conversation

brainandforce
Copy link
Owner

For some reason, Documenter.jl reliably fails to build the documentation for this package, and I need to fix it - here are the attempts (using CI runs for this testing).

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (b9c1d69) 58.07% compared to head (8fdbd04) 58.07%.

❗ Current head 8fdbd04 differs from pull request most recent head f6994e4. Consider uploading reports for the commit f6994e4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #186   +/-   ##
=======================================
  Coverage   58.07%   58.07%           
=======================================
  Files          19       19           
  Lines        1405     1405           
=======================================
  Hits          816      816           
  Misses        589      589           
Files Coverage Δ
src/data/bands.jl 0.00% <ø> (ø)
src/lattices.jl 74.11% <100.00%> (ø)
src/software/vasp.jl 52.26% <ø> (ø)
src/data/kpoints.jl 70.27% <0.00%> (-1.96%) ⬇️
src/data/wavefunctions.jl 58.73% <0.00%> (ø)
src/data/grids.jl 57.04% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brainandforce brainandforce merged commit a724209 into main Oct 18, 2023
3 checks passed
@brainandforce brainandforce deleted the fix/documentation-builds branch October 18, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant