Removed functions that widen grades for multiplication

brainandforce · May 8, 2024 · 554f035 · 554f035
1 parent 42c6008
commit 554f035
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/math.jl b/src/math.jl
@@ -170,7 +170,7 @@ Calculates the geometric product of `x` and `y`, returning the smallest type whi
 represent all nonzero basis blades of the result.
 """
 @inline function *(x::AbstractCliffordNumber{Q}, y::AbstractCliffordNumber{Q}) where Q
-    return mul(scalar_promote(widen_grade_for_mul(x), widen_grade_for_mul(y))...)
+    return mul(scalar_promote(x, y)...)
 end
 
 # KVector{0,Q} is just a scalar compatible with an AbstractCliffordNumber{Q}

diff --git a/src/multiply.jl b/src/multiply.jl
@@ -31,8 +31,9 @@ function nondegenerate_mask(a::BitIndex{Q}, B::NTuple{L,BitIndex{Q}}) where {L,Q
     return map(b -> nondegenerate_mult(a, b), B)
 end
 
+#=
 """
-    CliffordNumbers.widen_for_mul(x::AbstractCliffordNumber)
+    CliffordNumbers.widen_grade_for_mul(x::AbstractCliffordNumber)
 
 Widens `x` to an `EvenCliffordNumber`, `OddCliffordNumber`, or `CliffordNumber` as appropriate
 for the fast multiplication kernel.
@@ -46,6 +47,7 @@ function widen_grade_for_mul(x::AbstractCliffordNumber)
     all(iodd, nonzero_grades(x)) && return OddCliffordNumber(x)
     return CliffordNumber(x)
 end
+=#
 
 #---Grade filters----------------------------------------------------------------------------------#
 """