Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tooltips #955

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Improve tooltips #955

merged 3 commits into from
Aug 30, 2023

Conversation

smbea
Copy link
Contributor

@smbea smbea commented Aug 23, 2023

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Aug 23, 2023
@smbea smbea mentioned this pull request Aug 22, 2023
Closed
5 tasks
@smbea
Copy link
Contributor Author

smbea commented Aug 23, 2023

@christian-konrad could you have a look at this? Please review the content and let me know if anything is missing too. You can test them out in the modeler:
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/tooltips/camunda-modeler-tooltips-linux-x64.tar.gz
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/tooltips/camunda-modeler-tooltips-mac.dmg
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/tooltips/camunda-modeler-tooltips-mac.zip
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/tooltips/camunda-modeler-tooltips-win-ia32.zip
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/tooltips/camunda-modeler-tooltips-win-x64.zip

@smbea
Copy link
Contributor Author

smbea commented Aug 25, 2023

I will pick this up after my FTO since it isn't urgent. Also feel free to take over and merge, if you see fit.

@nikku nikku added the ready Ready to be worked on label Aug 28, 2023 — with bpmn-io-tasks
@nikku nikku removed the in progress Currently worked on label Aug 28, 2023
christian-konrad
christian-konrad approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@christian-konrad christian-konrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I updated some tooltips to remove ambiguity and to update them (some docs where this was taken from are outdated)

@christian-konrad christian-konrad marked this pull request as ready for review August 30, 2023 10:15
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed ready Ready to be worked on labels Aug 30, 2023
@philippfromme
Copy link
Contributor

philippfromme commented Aug 30, 2023 •
edited
Loading

@christian-konrad Fixed the merge conflict. Can be merged now.

@philippfromme philippfromme merged commit 8dde991 into main Aug 30, 2023
7 checks passed
@philippfromme philippfromme deleted the improve-tooltips branch August 30, 2023 12:05
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-konrad christian-konrad christian-konrad approved these changes

Assignees

@smbea smbea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smbea @philippfromme @christian-konrad @nikku