-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add _Binding_ entry to busines rule task, call activity and user task #1067
Conversation
eac64dd
to
875e3ff
Compare
I'm cross posting a concern from the upstream PR here: The design sketches seem to imply we now start to recommend best actions for users (in italic). I don't like this for two reasons:
My proposal is that we leave it to the documentation to give advice, and ensure that we properly apply sensible defaults, based on the context (ref). At best a user should not need to touch this property at all in order to be successful. |
875e3ff
to
1dc9e73
Compare
@nikku I drastically simplified the tooltip. |
@philippfromme Don't get me wrong: A short and concise factual description, if correct can help. I'd just want to keep out any detailed "recommendation" out of these tooltips. |
I think we should either leave out "The default is Ideally, we should keep the user in the application, rather than forcing them to go visit the documentation. To that end, I'd prefer a tooltip with a little more explanation, because the meanings and benefits of the options may not be obvious from their titles. How about a middle-of-the-road version along these lines? We could probably tighten the text up even more. Conversely, if we can nail down the right recommendations, I'd be OK with adding them back in. |
@lmbateman I think your proposal works well; I'd add
|
The Version tag option is not going to be supported according to https://github.com/camunda/product-hub/issues/1920#issuecomment-2168146584 so I didn't implement that. I assume, this would be added as part of https://github.com/camunda/product-hub/issues/435. |
5492b34
to
b125eb3
Compare
b125eb3
to
b026ec3
Compare
I've left out the documentation link since there is none yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the "uses the most recent..." proposal to "binds to..." in the tooltip, but this is good enough. ✅ from me.
b026ec3
to
d8b04e6
Compare
Ok, adjusted. |
Proposed Changes
Check out the branch and run
npm start
to test.Business rule tasks
Call activities
User tasks
Depends on camunda/camunda-bpmn-js-behaviors#78
Depends on bpmn-io/properties-panel#376
Tooltip
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}
Related to camunda/camunda-modeler#4385