chore: simplify eslint config

bpmn-io · Oct 16, 2024 · 901a426 · 901a426
1 parent e166a4a
commit 901a426
Show file tree

Hide file tree

Showing 2 changed files with 54 additions and 28 deletions.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -2,16 +2,50 @@ import bpmnIoPlugin from 'eslint-plugin-bpmn-io';
 import reactHooksPlugin from 'eslint-plugin-react-hooks';
 import importPlugin from 'eslint-plugin-import';
 
-const buildScripts = [ '*.js', '*.mjs' ];
+const files = {
+  build: [
+    '*.js',
+    '*.mjs',
+    'test/distro/distroSpec.js'
+  ],
+  test: [
+    'test/**/*.js'
+  ],
+  ignored: [
+    'dist',
+    'preact'
+  ]
+};
+
 
 export default [
   {
-    ignores: [
-      'dist'
-    ]
+    ignores: files.ignored
   },
-  ...bpmnIoPlugin.configs.browser,
-  ...bpmnIoPlugin.configs.jsx,
+
+  // build
+  ...bpmnIoPlugin.configs.node.map(config => {
+    return {
+      ...config,
+      files: files.build
+    };
+  }),
+
+  // lib + test
+  ...bpmnIoPlugin.configs.browser.map(config => {
+    return {
+      ...config,
+      ignores: files.build
+    };
+  }),
+  ...bpmnIoPlugin.configs.jsx.map(config => {
+    return {
+      ...config,
+      ignores: files.build
+    };
+  }),
+
+  // misc
   {
     plugins: {
       'react-hooks': reactHooksPlugin,
@@ -23,39 +57,30 @@ export default [
       'import/no-amd': 'error',
       'import/no-webpack-loader-syntax': 'error',
       'react-hooks/exhaustive-deps': 'off'
+    },
+    ignores: files.build
+  },
+  {
+    rules: {
+      'react/display-name': 'off',
+      'react/no-unescaped-entities': 'off'
     }
   },
-  ...bpmnIoPlugin.configs.node.map(config => {
-    return {
-      ...config,
-      files: [
-        ...buildScripts,
-        '**/test/**/*.js'
-      ]
-    };
-  }),
+
+  // test
   ...bpmnIoPlugin.configs.mocha.map(config => {
     return {
       ...config,
-      files: [
-        '**/test/**/*.js'
-      ]
+      files: files.test
     };
   }),
   {
     languageOptions: {
       globals: {
-        sinon: true
+        sinon: true,
+        require: true
       },
     },
-    files: [
-      '**/test/**/*.js'
-    ]
-  },
-  {
-    rules: {
-      'react/display-name': 'off',
-      'react/no-unescaped-entities': 'off'
-    }
+    files: files.test
   }
 ];
diff --git a/test/TestHelper.js b/test/TestHelper.js
@@ -34,6 +34,7 @@ const DEFAULT_AXE_RULES = [
 
 let PROPERTIES_PANEL_CONTAINER;
 
+// eslint-disable-next-line no-undef
 global.chai.use(function(chai, utils) {
 
   utils.addMethod(chai.Assertion.prototype, 'jsonEqual', function(comparison) {