Skip to content

Commit

Permalink
prep build 07/28
Browse files Browse the repository at this point in the history
  • Loading branch information
bph committed Jul 28, 2023
2 parents 3e0bd61 + 1536fee commit b5fc7f0
Show file tree
Hide file tree
Showing 142 changed files with 6,011 additions and 3,942 deletions.
4 changes: 2 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ https://github.com/WordPress/gutenberg/blob/trunk/CONTRIBUTING.md -->

## Testing Instructions
<!-- Please include step by step instructions on how to test this PR. -->
<!-- 1. Open a Post or Page. -->
<!-- 2. Insert a Heading Block. -->
<!-- 1. Open a post or page. -->
<!-- 2. Insert a heading block. -->
<!-- 3. etc. -->

### Testing Instructions for Keyboard
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/enforce-pr-labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
with:
mode: exactly
count: 1
labels: "[Type] Accessibility (a11y), [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Security, [Type] WP Core Ticket"
labels: "[Type] Accessibility (a11y), [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket"
add_comment: true
message: "## ⚠️ Type of PR label error\n To merge this PR, it requires {{ errorString }} {{ count }} label indicating the type of PR. Other labels are optional and not being checked here. \n- **Type-related labels to choose from**: {{ provided }}.\n- **Labels found**: {{ applied }}."
exit_type: success
message: "## ⚠️ Type of PR label error\n To merge this PR, it requires {{ errorString }} {{ count }} label indicating the type of PR. Other labels are optional and not being checked here. \n- **Type-related labels to choose from**: {{ provided }}.\n- **Labels found**: {{ applied }}.\n\nYou can learn more about the Type labels in Gutenberg [here](https://github.com/WordPress/gutenberg/labels?q=type)"
exit_type: failure
2 changes: 1 addition & 1 deletion .github/workflows/rnmobile-android-runner.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
uses: ./.github/setup-node

- name: Gradle cache
uses: gradle/gradle-build-action@6095a76664413da4c8c134ee32e8a8ae900f0f1f # v2.4.0
uses: gradle/gradle-build-action@8e02c8272aba4650563824b7012f8a86158901c6 # v2.5.0

- name: AVD cache
uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8 # v3.3.1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/storybook-pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
run: npm run storybook:build

- name: Deploy
uses: peaceiris/actions-gh-pages@64b46b4226a4a12da2239ba3ea5aa73e3163c75b # v3.9.1
uses: peaceiris/actions-gh-pages@373f7f263a76c20808c831209c920827a82a2847 # v3.9.3
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
publish_dir: ./storybook/build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ jobs:
wordpress: [''] # Latest WordPress version.
include:
# Test with the previous WP version.
- php: '5.6'
- php: '7.0'
wordpress: ${{ needs.compute-previous-wordpress-version.outputs.previous-wordpress-version }}
- php: '7.4'
wordpress: ${{ needs.compute-previous-wordpress-version.outputs.previous-wordpress-version }}
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,5 @@ phpunit-watcher.yml
test/storybook-playwright/test-results
test/storybook-playwright/specs/__snapshots__
test/storybook-playwright/specs/*-snapshots/**
test/gutenberg-test-themes/twentytwentyone
test/gutenberg-test-themes/twentytwentythree
21 changes: 19 additions & 2 deletions bin/plugin/commands/changelog.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ const LABEL_TYPE_MAPPING = {
'Automated Testing': 'Tools',
'[Package] Dependency Extraction Webpack Plugin': 'Tools',
'[Type] Code Quality': 'Code Quality',
'[Type] Accessibility (a11y)': 'Accessibility',
'[Type] Performance': 'Performance',
'[Type] Security': 'Security',
'[Feature] Navigation Screen': 'Experiments',
Expand Down Expand Up @@ -125,7 +126,6 @@ const LABEL_FEATURE_MAPPING = {
'[Block] Legacy Widget': 'Widgets Editor',
'REST API Interaction': 'REST API',
'New Block': 'Block Library',
'Accessibility (a11y)': 'Accessibility',
'[Package] E2E Tests': 'Testing',
'[Package] E2E Test Utils': 'Testing',
'Automated Testing': 'Testing',
Expand All @@ -149,6 +149,7 @@ const GROUP_TITLE_ORDER = [
'Enhancements',
'New APIs',
'Bug Fixes',
`Accessibility`,
'Performance',
'Experiments',
'Documentation',
Expand Down Expand Up @@ -468,6 +469,21 @@ const createOmitByLabel = ( labels ) => ( text, issue ) =>
? undefined
: text;

/**
* Higher-order function which returns a normalization function to omit by issue
* label starting with any of the given prefixes
*
* @param {string[]} prefixes Label prefixes from which to determine if given entry
* should be omitted.
*
* @return {WPChangelogNormalization} Normalization function.
*/
const createOmitByLabelPrefix = ( prefixes ) => ( text, issue ) =>
issue.labels.some( ( label ) =>
prefixes.some( ( prefix ) => label.name.startsWith( prefix ) )
)
? undefined
: text;
/**
* Given an issue title and issue, returns the title with redundant grouping
* type details removed. The prefix is redundant since it would already be clear
Expand Down Expand Up @@ -512,7 +528,7 @@ function removeFeaturePrefix( text ) {
* @type {Array<WPChangelogNormalization>}
*/
const TITLE_NORMALIZATIONS = [
createOmitByLabel( [ 'Mobile App Android/iOS' ] ),
createOmitByLabelPrefix( [ 'Mobile App' ] ),
createOmitByTitlePrefix( [ '[rnmobile]', '[mobile]', 'Mobile Release' ] ),
removeRedundantTypePrefix,
reword,
Expand Down Expand Up @@ -1039,6 +1055,7 @@ async function getReleaseChangelog( options ) {
capitalizeAfterColonSeparatedPrefix,
createOmitByTitlePrefix,
createOmitByLabel,
createOmitByLabelPrefix,
addTrailingPeriod,
getNormalizedTitle,
getReleaseChangelog,
Expand Down
15 changes: 8 additions & 7 deletions bin/plugin/commands/test/__snapshots__/changelog.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ exports[`getChangelog verify that the changelog is properly formatted 1`] = `
#### Components
- Add new ColorPicker. ([33714](https://github.com/WordPress/gutenberg/pull/33714))
- Update snackbar to use framer motion instead of react spring. ([33717](https://github.com/WordPress/gutenberg/pull/33717))
- Use updated range styles. ([33824](https://github.com/WordPress/gutenberg/pull/33824))
#### Block Library
- [Post Featured Image]: Add basic dimension controls. ([31634](https://github.com/WordPress/gutenberg/pull/31634))
Expand Down Expand Up @@ -76,13 +75,18 @@ exports[`getChangelog verify that the changelog is properly formatted 1`] = `
#### Meta Boxes
- Fix Safari 13 metaboxes from overlapping the content. ([33817](https://github.com/WordPress/gutenberg/pull/33817))
#### Accessibility
- Fix some JAWS bugs. ([33627](https://github.com/WordPress/gutenberg/pull/33627))
#### Template Editor
- Template: Only show post template actions to users with correct capabilities. ([33392](https://github.com/WordPress/gutenberg/pull/33392))
### Accessibility
- Fix some JAWS bugs. ([33627](https://github.com/WordPress/gutenberg/pull/33627))
#### Components
- Use updated range styles. ([33824](https://github.com/WordPress/gutenberg/pull/33824))
### Performance
- Avoid double parsing the content when loading the editor. ([33727](https://github.com/WordPress/gutenberg/pull/33727))
Expand Down Expand Up @@ -173,8 +177,6 @@ exports[`getChangelog verify that the changelog is properly formatted 1`] = `
### Various
- Core Data: Deprecate \`getAuthors\` in favor of \`getUsers\`. ([33725](https://github.com/WordPress/gutenberg/pull/33725))
- RNMobile: Add integration test guide. ([33833](https://github.com/WordPress/gutenberg/pull/33833))
- RNMobile: Try unifying the unit test command on mobile. ([33657](https://github.com/WordPress/gutenberg/pull/33657))
- Tune appender margin. ([33866](https://github.com/WordPress/gutenberg/pull/33866))
#### Block Library
Expand All @@ -192,7 +194,6 @@ exports[`getChangelog verify that the changelog is properly formatted 1`] = `
- Try to fix flaky customizer inspector test. ([33890](https://github.com/WordPress/gutenberg/pull/33890))
#### Block Editor
- Closing the block inserter decrements block type impressions. ([33906](https://github.com/WordPress/gutenberg/pull/33906))
- Enable rich previews for internal links. ([33086](https://github.com/WordPress/gutenberg/pull/33086))
#### Icons
Expand Down
2 changes: 1 addition & 1 deletion bin/plugin/commands/test/changelog.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ describe( 'getNormalizedTitle', () => {
undefined,
{
...DEFAULT_ISSUE,
labels: [ { name: 'Mobile App Android/iOS' } ],
labels: [ { name: 'Mobile App - i.e. Android or iOS' } ],
},
],
[
Expand Down
4 changes: 2 additions & 2 deletions bin/plugin/commands/test/fixtures/pull-requests.json
Original file line number Diff line number Diff line change
Expand Up @@ -5750,7 +5750,7 @@
"id": 546517042,
"node_id": "MDU6TGFiZWw1NDY1MTcwNDI=",
"url": "https://api.github.com/repos/WordPress/gutenberg/labels/Accessibility%20(a11y)",
"name": "Accessibility (a11y)",
"name": "[Type] Accessibility (a11y)",
"color": "655104",
"default": false,
"description": "Changes that impact accessibility and need corresponding review (e.g. markup changes)."
Expand Down Expand Up @@ -12552,7 +12552,7 @@
"id": 546517042,
"node_id": "MDU6TGFiZWw1NDY1MTcwNDI=",
"url": "https://api.github.com/repos/WordPress/gutenberg/labels/Accessibility%20(a11y)",
"name": "Accessibility (a11y)",
"name": "[Type] Accessibility (a11y)",
"color": "655104",
"default": false,
"description": "Changes that impact accessibility and need corresponding review (e.g. markup changes)."
Expand Down
Loading

0 comments on commit b5fc7f0

Please sign in to comment.