Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added metrics to Smartling TMS sync #966

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Added metrics to Smartling TMS sync #966

merged 2 commits into from
Jul 26, 2023

Conversation

maallen
Copy link
Contributor

@maallen maallen commented Jul 24, 2023

Adds latency metrics to the Smartling Third Party Sync to enable a better understanding of where performance bottlenecks may occur.

@maallen
Copy link
Contributor Author

maallen commented Jul 25, 2023

@aurambaj Just to note that there is some existing instrumentation on the overall push/pull methods using the @Timed annotation

@Timed("SmartlingSync.push")

however we can't use tags with this approach as the specific runtime repo/locale isn't available at compile time. With this in mind should I remove the above annotation and rename the new stats to match the old stat or leave them as they are in the PR at present?

https://github.com/box/mojito/pull/966/files#diff-debc760cec87b95894f514bc911c2692b8a928ac4052d0ad121a930f17d7127aR375

@aurambaj
Copy link
Collaborator

With this in mind should I remove the above annotation and rename the new stats to match the old stat or leave them as they are in the PR at present?

Good question. The annotation comes with 2 tags: method and class name. Those tags would be gone with the new code. Classname could be easily added back. The method not so much but I don't think we truly use those.

One thing i've been thinking was to change the aspect to support "tags extraction" from the method params, like what we do in PollableTask. That can also prevent some issues with "final" requirement.

With that said, it feels like we can reuse the old name and just drop those 2 tags since we have that in the metric name

@aurambaj aurambaj merged commit a05fa52 into box:master Jul 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants