Fix tests on macOS

[danepowell]

I'll admit I don't quite understand why this is failing, but I'm guessing no one has actually run tests on macOS recently and this broke sometime along the way.

[theofidry]

I'll be honest... I have no clue neither, looks like it's failing for me now... I'll try to check it again

[theofidry]

Now I am getting:

-    'timestamp' => 1680317060
+    'timestamp' => 1680284660

And launching this in psysh I'm getting:

> (new SplFileInfo('fixtures/phar/simple.zip'))->getMTime()
= 1697988274

> (new PharData('fixtures/phar/simple.zip'))->getMTime()
= 1680284660

So frankly I don't quite get it

[danepowell]

@theofidry a shot in the dark here... what's the value of PHP_OS_FAMILY on your machine?

I wonder if you're using a cross-compiled version of PHP on MacOS and getting bit by tivie/php-os-detector#3

If that's the case, we should consider dropping the use of PHP_OS_FAMILY for something more reliable, as I've had to do in the past: acquia/blt#3750

[theofidry]

@theofidry a shot in the dark here... what's the value of PHP_OS_FAMILY on your machine?

PHP_OS_FAMILY = PHP_OS = 'Darwin'

The PHP binary has been compiled by https://github.com/phpbrew/phpbrew on this very machine.

But... wow yeah that's an edge case alright

[danepowell]

I'll try to take a deeper look at these tests later this week if you don't get to it sooner. I'm on a Macbook M1, macOS 13.6, running brew php. I'm guessing the difference has to do with one of these versions.

[danepowell]

I didn't realize you'd added the macOS conditional just a day earlier: #1104

Anyway... I think this timestamp you referenced is the last modified time of the zip file, which is basically when you checked it out from the repo: 1697988274

I think the timestamp for the phar is based on the txt file inside, which is either 1680317060 or 1680284660.

The fact that these are exactly 9 hours apart makes me think this is a timezone issue. Like, some version of the zlib library (provided on macOS) isn't handling timezone conversion correctly.

[danepowell]

Congratulations, I think we've stumbled across a PHP bug: php/php-src#12532

[theofidry]

Thanks very much for looking into this and opening the issue! It's unfortunate it's a PHP bug, but I'm happy it's not me going crazy!

[danepowell]

This should be good to go. Perhaps you can restart the rate-limited tests.

[theofidry]

Thanks a lot @danepowell! really glad to see one of those pestering issues gone 😄