fix: Add missing cast for the sort function of the requirement builder (

#1335)
box-project · Mar 13, 2024 · b151b4b · b151b4b
1 parent 70f998e
commit b151b4b
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 1 deletion.
diff --git a/src/RequirementChecker/RequirementsBuilder.php b/src/RequirementChecker/RequirementsBuilder.php
@@ -138,7 +138,7 @@ static function (array $sources): array {
                 usort(
                     $sources,
                     static fn (array $sourceTypePairA, array $sourceTypePairB) => strcmp(
-                        $sourceTypePairA[0],
+                        (string) $sourceTypePairA[0],
                         (string) $sourceTypePairB[0],
                     ),
                 );

diff --git a/tests/RequirementChecker/RequirementsBuilderTest.php b/tests/RequirementChecker/RequirementsBuilderTest.php
@@ -108,9 +108,40 @@ public function test_it_can_build_requirements_from_provided_extensions(): void
             new Extension('http'),
             'package2',
         );
+        $this->builder->addProvidedExtension(
+            new Extension('http'),
+            null,
+        );
+
+        $expectedBuiltRequirements = new Requirements([]);
+        $expectedAllRequirements = new Requirements([
+            Requirement::forProvidedExtension('http', null),
+            Requirement::forProvidedExtension('http', 'package1'),
+            Requirement::forProvidedExtension('http', 'package2'),
+        ]);
+
+        $this->assertBuiltRequirementsEquals($expectedBuiltRequirements);
+        $this->assertAllRequirementsEquals($expectedAllRequirements);
+    }
+
+    public function test_it_can_build_requirements_from_provided_extensions_sorting_edge_case(): void
+    {
+        $this->builder->addProvidedExtension(
+            new Extension('http'),
+            null,
+        );
+        $this->builder->addProvidedExtension(
+            new Extension('http'),
+            'package1',
+        );
+        $this->builder->addProvidedExtension(
+            new Extension('http'),
+            'package2',
+        );
 
         $expectedBuiltRequirements = new Requirements([]);
         $expectedAllRequirements = new Requirements([
+            Requirement::forProvidedExtension('http', null),
             Requirement::forProvidedExtension('http', 'package1'),
             Requirement::forProvidedExtension('http', 'package2'),
         ]);