Skip to content

Commit

Permalink
build: Use more portable colours (#1019)
Browse files Browse the repository at this point in the history
Currently the make command fails because the `bin/sh` shell used does
not handle ANSI escape codes for the colour formatting.

Instead, we use `$(shell ...)` functions to execute a command that
produces the ANSI escape codes.
  • Loading branch information
theofidry authored Oct 6, 2023
1 parent 3805f6d commit 315a9c1
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ MAKEFLAGS += --warn-undefined-variables
MAKEFLAGS += --no-builtin-rules

OS := $(shell uname)
ERROR_COLOR := "\033[41m"
YELLOW_COLOR = "\033[0;33m"
NO_COLOR = "\033[0m"
ERROR_COLOR := $(shell tput setab 1)
YELLOW_COLOR := $(shell tput setaf 3)
NO_COLOR := $(shell tput sgr0)

COMPOSER_BIN_PLUGIN_VENDOR = vendor/bamarni/composer-bin-plugin

Expand Down
6 changes: 3 additions & 3 deletions requirement-checker/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ MAKEFLAGS += --warn-undefined-variables
MAKEFLAGS += --no-builtin-rules

OS := $(shell uname)
ERROR_COLOR := "\033[41m"
YELLOW_COLOR := "\033[0;33m"
NO_COLOR := "\033[0m"
ERROR_COLOR := $(shell tput setab 1)
YELLOW_COLOR := $(shell tput setaf 3)
NO_COLOR := $(shell tput sgr0)


PHPUNIT_BIN = vendor/bin/phpunit
Expand Down

0 comments on commit 315a9c1

Please sign in to comment.