Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/lambda functions #230

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Task/lambda functions #230

wants to merge 15 commits into from

Conversation

ybastide
Copy link
Contributor

@ybastide ybastide commented Mar 4, 2017

Missing:

  • documentation
  • simpleflow.LambdaFunctionTask?
  • "local" support?

@ybastide ybastide mentioned this pull request Mar 6, 2017
@ybastide ybastide requested a review from jbbarth March 29, 2017 09:24
@ybastide ybastide modified the milestone: 0.17.0 Jun 10, 2017
@ybastide ybastide force-pushed the task/lambda-functions branch 2 times, most recently from 43ca4a0 to 6351703 Compare June 25, 2017 12:15
Unfortunately, boto2 doesn't support passing lambdaRole; we must
override two of its methods (register type and start workflow).

Signed-off-by: Yves Bastide <[email protected]>
Currently SWF only; needs to be moved upward. And with some rough
edges...

Signed-off-by: Yves Bastide <[email protected]>
"name" is really set to "id" (more useful).

Signed-off-by: Yves Bastide <[email protected]>
* use workflow_config.`get('defaultLambdaRole')` instead of [] (not
    already present, at least in tests)
* rename my_* to custom_*

Signed-off-by: Yves Bastide <[email protected]>
Signed-off-by: Yves Bastide <[email protected]>
Signed-off-by: Yves Bastide <[email protected]>
Signed-off-by: Yves Bastide <[email protected]>
This at least document its format :-)

Signed-off-by: Yves Bastide <[email protected]>
Signed-off-by: Yves Bastide <[email protected]>
Currently SWF only; needs to be moved upward. And with some rough
edges...

Signed-off-by: Yves Bastide <[email protected]>
"name" is really set to "id" (more useful).

Signed-off-by: Yves Bastide <[email protected]>
Signed-off-by: Yves Bastide <[email protected]>
Base automatically changed from master to main March 9, 2021 09:06
Copy link
Collaborator

@jbbarth jbbarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey dear @ybastide I hope everything's OK on your side :) Adding a "review ok" here to reduce noise in my Github "Pulls" dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants