Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/check fails with NoneType #64

Merged
merged 55 commits into from
Mar 28, 2024
Merged

Bugfix/check fails with NoneType #64

merged 55 commits into from
Mar 28, 2024

Conversation

ct2034
Copy link
Member

@ct2034 ct2034 commented Mar 28, 2024

fixes #57

dependabot bot and others added 30 commits October 2, 2023 22:41
@dependabot
Update scancode-toolkit requirement from <=31.2.6 to <=32.0.7
be4a47c 
Updates the requirements on [scancode-toolkit](https://github.com/nexB/scancode-toolkit) to permit the latest version.
- [Release notes](https://github.com/nexB/scancode-toolkit/releases)
- [Changelog](https://github.com/nexB/scancode-toolkit/blob/develop/CHANGELOG.rst)
- [Commits](aboutcode-org/scancode-toolkit@v1.0.0...v32.0.7)

---
updated-dependencies:
- dependency-name: scancode-toolkit
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@ct2034
working from 32.0.7
53dc988 
Signed-off-by: Christian Henkel <[email protected]>
@ct2034
is_license_text check fixed with new result semantics
85df286 
Signed-off-by: Christian Henkel <[email protected]>
@ct2034
linting fix
db494df 
Signed-off-by: Christian Henkel <[email protected]>
@ct2034
handling of ignored files
ca0e3e1 
Signed-off-by: Christian Henkel <[email protected]>
@ct2034
formatting
c53c22b 
Signed-off-by: Christian Henkel <[email protected]>
@ct2034
this is all WIP
073e6fb 
Signed-off-by: Christian Henkel <[email protected]>
@ct2034
Merge branch 'main' into dependabot/pip/scancode-toolkit-lte-32.0.7
6555c19
@ct2034
Unnecessary "else" after "return"
5312b77 
Signed-off-by: Christian Henkel <[email protected]>
@ct2034
still bad with 32.0.8
d747147 
Signed-off-by: Christian Henkel <[email protected]>
@ct2034
ignoring those rules
8f18304 
Signed-off-by: Christian Henkel <[email protected]>
@ant-u
Merge branch 'main' into dependabot/pip/scancode-toolkit-lte-32.0.7
dada029
@ant-u
changed method get_spdx_license_name back, WIP
f633c28 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
scancode get_copyrights function filtering word 'anything', changed t…
1e7a499 
…o second

Signed-off-by: Anton Utz <[email protected]>
@ant-u
linter issues
b5d3b25 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
Added spaces around comment for scancode to recognize copyright message
fd8d6de 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
Merge branch 'main' of https://github.com/boschresearch/ros_license_t…
af457d3 
…oolkit into dependabot/pip/scancode-toolkit-lte-32.0.7

Signed-off-by: Anton Utz <[email protected]>
@ant-u
added check for only one license text which is in spdx to start handl…
648de94 
…ing wrong tags as the license of the file

Signed-off-by: Anton Utz <[email protected]>
@ant-u
When only one SPDX License File exists, make a warning to change the …
59be16e 
…wrong tag

Signed-off-by: Anton Utz <[email protected]>
@ant-u
Added check if multiple files exist
27393ff 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
restructured LicenseTextExistsCheck
28cede1 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
reverted restructure of check since pytest has trouble with it
eec394c 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
moved LicenseTextExists checks to seperate function
b7859b4 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
made own evaluation function for licenseInCodeCheck
9aefe6a 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
added irgnore flag for too many attributes localy to package.py since…
945cd93 
… this is the only place where saving inofficial licenses makes sense

Signed-off-by: Anton Utz <[email protected]>
@ant-u
Converted check_licenses mehtod to function
622738e 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
restructured Check LicensesInCode and TextExists to work with attribu…
75c2d63 
…tes instead of local vars

Signed-off-by: Anton Utz <[email protected]>
@ant-u
added test for two licenses with both tags not in spdx
6c9ba21 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
changed license from test to MPL
5af585d 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
Added negative test for two not in spdx tags but one for own license …
89f05d9 
…file

Signed-off-by: Anton Utz <[email protected]>
ant-u and others added 25 commits March 11, 2024 11:11
@ant-u
added test for ignoring contents of readme
f51e03b 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
added ignore file in json format to set all files, types and folders …
4590a29 
…for ignoring

Signed-off-by: Anton Utz <[email protected]>
@ant-u
added test for hidden folder that should also be ignored (simulating …
07f813e 
…git folder). Changed format of ignore file

Signed-off-by: Anton Utz <[email protected]>
@ant-u
merged two lines
4ee05fe 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
changed check for LicenceTag to Fail if tag and file are not same lic…
065ff46 
…ense but both are SPDX

Signed-off-by: Anton Utz <[email protected]>
@ct2034
Documenting requirements for pypi update (#56)
87bd4fc 
Signed-off-by: Christian Henkel <[email protected]>
@ant-u
Merge branch 'main' into feature/handling-false-positives
690dfc6 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
linter issues
3a99d0e 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
Merge branch 'main' into feature/error_for_spdx_license_and_tag
2c861e9 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
deleted unnecessary attribute from pull request
cecde49 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
Added check for LicenenseInCode if src file has a license declaration…
3ab9062 
… in SPDX. Otherwise, display warning

Signed-off-by: Anton Utz <[email protected]>
@ant-u
introduced .scanignore file, keeping local var for ignoring default f…
371d631 
…iles.

Signed-off-by: Anton Utz <[email protected]>
@ant-u
Added list of default ignored items to readme
0a9573b 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
Merge branch 'main' into feature/handling-false-positives
60b824e 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
Merge pull request #54 from boschresearch/feature/error_for_spdx_lice…
87b062a 
…nse_and_tag

Feature/error for spdx license and tag
@ant-u
Merge pull request #53 from boschresearch/feature/handling-false-posi…
0cb67b7 
…tives

Feature/handling false positives
@ant-u
Merge branch 'main' into bugfix/check_fails_with_nonetype
665a0b6
@ant-u
Feature: add check for every license has a matching tag (#55)
90afb3e 
* added check for lincense files not covered by any tag
* Added test for too many License files
* Added inofficial license check in LicenseFileReferenced to decide between error and warning. Introduced function for path is parent or child

---------

Signed-off-by: Anton Utz <[email protected]>
@ant-u
removed license file, adapted linting issues
855debb 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
removed extra code file from unkown license package
8f83c1f 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
Merge branch 'main' into bugfix/check_fails_with_nonetype
3569882
@ant-u
Added calls for test
ff8816b 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
removed trailing whitespace
9bb37b0 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
removed check for files with no license
e9fbcf3 
Signed-off-by: Anton Utz <[email protected]>
@ant-u
Adapted check
56f8712 
Signed-off-by: Anton Utz <[email protected]>
@ct2034 ct2034 merged commit b796456 into main Mar 28, 2024
17 of 23 checks passed
@ct2034 ct2034 deleted the bugfix/check_fails_with_nonetype branch March 28, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check Fails with AttributeError: 'NoneType'
2 participants
@ct2034 @ant-u