Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add check for every license has a matching tag #55

Merged
merged 7 commits into from
Mar 19, 2024

Conversation

ant-u
Copy link
Collaborator

@ant-u ant-u commented Mar 12, 2024

Added check for not referenced license declarations.
Check only gives out warnings if anything is found.
To make sure only local package is checked, everything above the package location is ignored (There were problems with declarations that were found but are not part of package)
Also added test that checks for these warnings.

@ant-u ant-u requested a review from ct2034 March 12, 2024 14:13
@ant-u ant-u self-assigned this Mar 12, 2024
@ant-u ant-u linked an issue Mar 12, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Mar 12, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
622 588 95% 90% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 54a3ac3 by action🐍

@ant-u ant-u changed the title Feature/add licence matching tag Feature/add license matching tag Mar 18, 2024
src/ros_license_toolkit/checks.py Outdated Show resolved Hide resolved
src/ros_license_toolkit/checks.py Show resolved Hide resolved
src/ros_license_toolkit/checks.py Outdated Show resolved Hide resolved
src/ros_license_toolkit/checks.py Outdated Show resolved Hide resolved
test/systemtest/test_separate_pkgs.py Outdated Show resolved Hide resolved
…ween error and warning. Introduced function for path is parent or child

Signed-off-by: Anton Utz <[email protected]>
@ant-u ant-u requested a review from ct2034 March 18, 2024 17:35
@ant-u ant-u changed the title Feature/add license matching tag Feature: add check for every license has a matching tag Mar 19, 2024
ct2034

This comment was marked as resolved.

@ct2034 ct2034 merged commit 90afb3e into main Mar 19, 2024
12 checks passed
@ct2034 ct2034 deleted the feature/add_licence_matching_tag branch March 19, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add check for every license being linked in package.xml
2 participants