Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/handling false positives #53

Merged
merged 9 commits into from
Mar 18, 2024
Merged

Conversation

ant-u
Copy link
Collaborator

@ant-u ant-u commented Mar 11, 2024

Changed the way we ignore files from global variable in package.py to top-level .json config file ignore_in_scan.json.
Added test for actually ignoring these files.

@ant-u ant-u marked this pull request as ready for review March 11, 2024 16:12
@ant-u ant-u changed the base branch from dependabot/pip/scancode-toolkit-lte-32.0.7 to main March 11, 2024 16:12
@ant-u ant-u closed this Mar 11, 2024
@ant-u ant-u linked an issue Mar 11, 2024 that may be closed by this pull request
@ant-u ant-u reopened this Mar 11, 2024
@ant-u ant-u requested a review from ct2034 March 11, 2024 16:14
@ant-u ant-u self-assigned this Mar 11, 2024
Copy link

github-actions bot commented Mar 11, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
594 560 94% 90% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 60b824e by action🐍

@ant-u
Copy link
Collaborator Author

ant-u commented Mar 11, 2024

For review maybe first look at PR of dependabot. This one builds upon that.

@ant-u ant-u requested review from ct2034 and removed request for ct2034 March 18, 2024 09:10
ignore_in_scan.json Outdated Show resolved Hide resolved
src/ros_license_toolkit/common.py Outdated Show resolved Hide resolved
src/ros_license_toolkit/package.py Show resolved Hide resolved
src/ros_license_toolkit/package.py Show resolved Hide resolved
@ant-u ant-u requested a review from ct2034 March 18, 2024 14:52
@ant-u ant-u merged commit 0cb67b7 into main Mar 18, 2024
12 checks passed
@ant-u ant-u deleted the feature/handling-false-positives branch March 18, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling false positives
2 participants