-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Github action #23
Conversation
This allows this repo being used as a GH action in other projects. Signed-off-by: Felix Exner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, @fmauch. To support this, I have fixed the versioning scheme for the package, which would then also be the version of the action that people could state when they use it, rather than the branch.
But I want to ask you to add a section and brief usage example to the README.md.
Explain how to use this tool inside a github workflow and checked the tick for a github action on the feature list. Signed-off-by: Felix Exner <[email protected]>
I've added an action usage section to the main README. It uses the latest version currently being present on the main branch. @ct2034 Do you plan to add tags for each version? Most actions that I know keep a major version tag running along the latest patch version. So in this case there would be a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the contribution. This looks awesome
* Added action.yml This allows this repo being used as a GH action in other projects. Signed-off-by: Felix Exner <[email protected]> * Added README entry about GitHub action Explain how to use this tool inside a github workflow and checked the tick for a github action on the feature list. Signed-off-by: Felix Exner <[email protected]> --------- Signed-off-by: Felix Exner <[email protected]> Co-authored-by: Christian Henkel <[email protected]> Signed-off-by: Christian Henkel <[email protected]>
* systems test that actually look at copyright files Signed-off-by: Christian Henkel <[email protected]> * support for url in Source Signed-off-by: Christian Henkel <[email protected]> * linter Signed-off-by: Christian Henkel <[email protected]> * Add Github action (#23) * Added action.yml This allows this repo being used as a GH action in other projects. Signed-off-by: Felix Exner <[email protected]> * Added README entry about GitHub action Explain how to use this tool inside a github workflow and checked the tick for a github action on the feature list. Signed-off-by: Felix Exner <[email protected]> --------- Signed-off-by: Felix Exner <[email protected]> Co-authored-by: Christian Henkel <[email protected]> Signed-off-by: Christian Henkel <[email protected]> * isort Signed-off-by: Christian Henkel <[email protected]> --------- Signed-off-by: Christian Henkel <[email protected]> Signed-off-by: Felix Exner <[email protected]> Co-authored-by: Felix Exner (fexner) <[email protected]>
This PR aims at adding a github action that could be included by other repos. At the time of creating this, there is a first working version that is probably not optimal (hence the draft), since I am rather new to the topic of writing custom actions.
You can see an example of this action being used here.
Obviously, the action could be moved to its own repository, as well, but I decided to include it here at least for a first, testable version.
Edit: I've been thinking that from my point of view, this might actually a valid solution that could act as a first version. Whether or not we want to use a more versioned approach or move the action to its own repo is something to decide for the maintainers.