Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HybridGaussianConditional inherits from HybridGaussianFactor #1836

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

varunagrawal
Copy link
Collaborator

Analogous to GaussianConditional and GaussianFactor, make HybridGaussianConditional inherit from HybridGaussianFactor so we can reduce code duplication.

I also changed logConstant_ to be defined in the negative logspace, letting us lower bound the values at 0.0 instead of $-\infty$. I'll be updating the Hybrid.pdf file to reflect this for synergy.

One of a bunch of small PRs to improve the hybrid API and functionality.

@varunagrawal varunagrawal self-assigned this Sep 20, 2024
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, but this makes me think that maybe all log constants should be in negative log space. Either k, or -log k. Never log k.

@varunagrawal
Copy link
Collaborator Author

LG, but this makes me think that maybe all log constants should be in negative log space. Either k, or -log k. Never log k.

Yeah I have been thinking about that as well.

@varunagrawal varunagrawal merged commit 017044e into develop Sep 20, 2024
33 checks passed
@varunagrawal varunagrawal deleted the improved-api branch September 20, 2024 19:26
@dellaert
Copy link
Member

LG, but this makes me think that maybe all log constants should be in negative log space. Either k, or -log k. Never log k.

Yeah I have been thinking about that as well.

I think we should do it. Will you or will I?

@varunagrawal
Copy link
Collaborator Author

I can get to it later tonight, if that works?

@varunagrawal
Copy link
Collaborator Author

Just to make sure I understand, the change is to update logNormalizationConstant so that it returns -log(k) where $k = \frac{1}{\sqrt{|2\pi \Sigma|}}$ right?
Currently that is the only method/function that works with log(k).

@dellaert
Copy link
Member

Yes. But there is one (or more?) in HC class hierarchy and one in noiseModel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants