-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HybridGaussianConditional inherits from HybridGaussianFactor #1836
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, but this makes me think that maybe all log constants should be in negative log space. Either k, or -log k. Never log k.
Yeah I have been thinking about that as well. |
I think we should do it. Will you or will I? |
I can get to it later tonight, if that works? |
Just to make sure I understand, the change is to update |
Yes. But there is one (or more?) in HC class hierarchy and one in noiseModel |
Analogous to
GaussianConditional
andGaussianFactor
, makeHybridGaussianConditional
inherit fromHybridGaussianFactor
so we can reduce code duplication.I also changed$-\infty$ . I'll be updating the
logConstant_
to be defined in the negative logspace, letting us lower bound the values at 0.0 instead ofHybrid.pdf
file to reflect this for synergy.One of a bunch of small PRs to improve the hybrid API and functionality.