Always pick GAS Lexer for .S files #316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tleb
reviewed
Aug 19, 2024
Currently, Pygments often picks SLexer for .S files. It's a lexer for files related to the R language. https://pygments.org/docs/lexers/#pygments.lexers.r.SLexer ``` >>> import pygments.lexers >>> pygments.lexers.guess_lexer_for_filename('arch/x86/boot/header.S', open('arch/x86/boot/header.S').read()) <pygments.lexers.SLexer> ``` This commits makes sure Elixir prefers the GAS lexer for .S files instead of SLexer. It's not the best heuristic, but better than picking the SLexer class sometimes. Currently, Elixir does not index any R language projects. In the future, it would be better to specify per-project information about what languages are used.
fstachura
force-pushed
the
pick-gas-lexer-for-s-files
branch
from
9fd6a5a
to
2afc86a
Compare
|
It still does not handle
New rendering:
I guess we can't do much more than pick the best Pygments lexer for the job. Many other things look more reasonable. It is merged as 43b4f72! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not the best heuristic, but better than always picking the SLexer class
https://pygments.org/docs/lexers/#pygments.lexers.r.SLexer
Currently, Elixir does not index any R language files