Skip to content

Commit

Permalink
Expanded comment re. windres.exe workaround.
Browse files Browse the repository at this point in the history
  • Loading branch information
Lastique committed Jun 13, 2024
1 parent 8c8124c commit 9a906e2
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,14 @@ if (WIN32)
set_source_files_properties("${CMAKE_CURRENT_BINARY_DIR}/src/windows/simple_event_log.rc" PROPERTIES GENERATED TRUE)

if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
# Workaround for a windres.exe issue: https://github.com/boostorg/log/pull/231
# Workaround for a windres.exe issue on MinGW-w64: by default, it uses popen to pipe preprocessed
# output from the preprocessor, but popen is buggy on non-English Windows systems and causes
# compilation errors such as:
#
# windres.exe: can't open file `page:': Invalid argument
#
# This option forces windres.exe to use a temporary file instead.
# https://github.com/boostorg/log/pull/231
list(APPEND CMAKE_RC_FLAGS "--use-temp-file")
endif()

Expand Down

0 comments on commit 9a906e2

Please sign in to comment.