로그인 화면 생성, 이메일/비밀번호 유효성 검사, 회원가입 화면으로 전환 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- inflate - viewmodel 생성 및 할당 - 회원가입 버튼 클릭 시 회원가입 UI로 이동
…nd09-PriceGuard into feat/and/login
…iceGuard into feat/and/login
4 tasks
4 tasks
This was
linked to
issues
Nov 15, 2023
Taewan-P
requested changes
Nov 15, 2023
android/app/src/main/java/app/priceguard/ui/login/LoginViewModel.kt
Outdated
Show resolved
Hide resolved
android/app/src/main/java/app/priceguard/ui/login/LoginViewModel.kt
Outdated
Show resolved
Hide resolved
android/app/src/main/java/app/priceguard/ui/login/LoginViewModel.kt
Outdated
Show resolved
Hide resolved
android/app/src/main/java/app/priceguard/ui/login/LoginActivity.kt
Outdated
Show resolved
Hide resolved
android/app/src/main/java/app/priceguard/ui/login/LoginViewModel.kt
Outdated
Show resolved
Hide resolved
ootr47
reviewed
Nov 15, 2023
android/app/src/main/java/app/priceguard/ui/login/LoginActivity.kt
Outdated
Show resolved
Hide resolved
android/app/src/main/java/app/priceguard/ui/login/LoginViewModel.kt
Outdated
Show resolved
Hide resolved
서버 로그인까지 고려했을 때 이벤트 발생 방식을 구현하는 것이 더 적합하다 판단했다. 팀원들에게 이에 대한 동의를 구했다.
ootr47
reviewed
Nov 16, 2023
android/app/src/main/java/app/priceguard/ui/login/LoginActivity.kt
Outdated
Show resolved
Hide resolved
android/app/src/main/java/app/priceguard/ui/login/LoginActivity.kt
Outdated
Show resolved
Hide resolved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
android/app/src/main/java/app/priceguard/ui/login/LoginViewModel.kt
Outdated
Show resolved
Hide resolved
android/app/src/main/java/app/priceguard/ui/login/LoginViewModel.kt
Outdated
Show resolved
Hide resolved
뷰모델의 함수를 호출해야 하기 때문
This was referenced Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #29 , resolves #33
진행 내용
스크린샷
Screen_recording_20231116_133555.mp4