Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

회원탈퇴 기능 추가 #239

Merged
merged 18 commits into from
Jan 25, 2024
Merged

회원탈퇴 기능 추가 #239

merged 18 commits into from
Jan 25, 2024

Conversation

ootr47
Copy link
Collaborator

@ootr47 ootr47 commented Dec 28, 2023 •
edited
Loading

진행 내용

  • 회원 탈퇴 ui 추가
  • 회원 탈퇴 api 연동

스크린샷

KakaoTalk_Video_2024-01-15-19-17-56.mp4

@ootr47 ootr47 added feature 새로운 기능 android 안드로이드 관련 labels Dec 28, 2023
@ootr47 ootr47 self-assigned this Dec 28, 2023
@ootr47 ootr47 marked this pull request as ready for review January 15, 2024 10:20
@boostcampwm2023 boostcampwm2023 deleted a comment from github-actions bot Jan 15, 2024
@boostcampwm2023 boostcampwm2023 deleted a comment from github-actions bot Jan 15, 2024
@boostcampwm2023 boostcampwm2023 deleted a comment from github-actions bot Jan 15, 2024
@boostcampwm2023 boostcampwm2023 deleted a comment from github-actions bot Jan 15, 2024
@boostcampwm2023 boostcampwm2023 deleted a comment from github-actions bot Jan 15, 2024
Taewan-P
Taewan-P requested changes Jan 15, 2024
View reviewed changes
Copy link
Member

@Taewan-P Taewan-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!
다만, UI적으로 탈퇴 요청이 이루어지는 동안 네트워크 요청이 처리되고 있다는게 사용자한테 보여지면 좋겠습니다.

android/app/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
android/app/src/main/java/app/priceguard/ui/home/mypage/MyPageSettingAdapter.kt Outdated Show resolved Hide resolved
android/app/src/main/java/app/priceguard/ui/util/ConfirmDialogFragment.kt Outdated Show resolved Hide resolved
android/app/src/main/java/app/priceguard/ui/home/mypage/DeleteAccountViewModel.kt Show resolved Hide resolved
EunhoKang
EunhoKang approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@EunhoKang EunhoKang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

큰 문제점은 안보이네요. 고생많으셨습니다.

Taewan-P
Taewan-P approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@Taewan-P Taewan-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!
ThrottleClick이 View를 확장했는데 ImageViewAdapter 처럼 BindingAdatper로 사용해도 좋을것 같습니다.

@Taewan-P Taewan-P merged commit d760460 into dev/and Jan 25, 2024
2 checks passed
@Taewan-P Taewan-P deleted the feat/and/delete-account branch May 21, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EunhoKang EunhoKang EunhoKang approved these changes

@Taewan-P Taewan-P Taewan-P approved these changes

Assignees

@ootr47 ootr47

Labels
android 안드로이드 관련 feature 새로운 기능
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ootr47 @Taewan-P @EunhoKang