-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue[19][20][25] solved. #33
base: master
Are you sure you want to change the base?
Conversation
Also, modified README.org for developers to get around the extra libraries to import. |
@DerekV Would you give this a peek and see if it works? |
Yep, will look later.
|
@DerekV Did you have time to get a look at the code? I can start working on other issues, only if this one is okay. |
@@ -46,6 +48,8 @@ private void dealWithIntents() { | |||
populateFields(bmark); | |||
} catch (JsonSyntaxException e) { | |||
Log.e(TAG, "Error getting bookmark detail", e); | |||
Toast.makeText(getActivity(),"Some error occured while fetching bookmark details" , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a string resource instead of hard-coding a string
Thanks for working on this @d4r3topk |
Thanks a lot @DerekV .I will address the style issues and update it. Yes, A style guide will save a lot of time for the other contributors. Also, Is committing on my branch(like this one) okay? And yes, I've checked the code on my android device, works fine. |
This commit is for the theme issues and informing user about "no username","failed to fetch bookmarks", and when "updating bookmarks".(basically when cannot talk to server) . Takes care of Issues 19,20,25. Some different import statements due to workspace imports.