-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add a tool to check links [POC] #618
base: master
Are you sure you want to change the base?
Conversation
🎊 PR Preview c7f6a8f has been successfully built and deployed to https://bonitasoft-bonita-documentation-site-test-pr-618.surge.sh 🕐 Build time: 0.013s 🤖 By surge-preview |
🎊 PR Preview 944a9bb has been successfully built and deployed to https://bonitasoft-bonita-documentation-site-site-pr-618.surge.sh 🕐 Build time: 0.013s 🤖 By surge-preview |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
.github/workflows/check-links.yml
Outdated
run: npm install --save-dev [email protected] | ||
- name: Build site | ||
run: | | ||
./build-preview-dev.bash --hide-edit-page-links true --force-production-navbar true --type links-check --component bonita --branch 2023.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quality Gate passedIssues Measures |
# Conflicts: # .github/workflows/build-pr-site.yml # .github/workflows/publish-pr-preview.yml
Quality Gate passedIssues Measures |
The former URL was still used and hardcoded in the "Studio Update" page. ### Notes Detected with bonitasoft/bonita-documentation-site#618 as part of bonitasoft/bonita-documentation-site#594
WIP
Covers #430 and #594.
Use
htmltest
: https://github.com/wjdp/htmltestConfiguration of the preview script use to build the site that is checked. This is why we are not using the production build for the checks:
The GH workflow enables the real use of Antora Atlas to resolve links to pages not built in the preview (links to pages related to unsupported versions). This may consume extra bandwidth in our Netlify plan.
Remaining tasks
IgnoreURLs
option - IgnoreDirs cannot be used as the dependencies pages are located in the ROOT module at the root of the directory.Example of preview commands to generate the site to check locally
Single component version
Note:
Build whole site (include bonita out of support version)
Command to only build supported versions
The real check requires to enable Antora Atlas.
Otherwise, some cross references are not resolved like
WARN: missing ref for bonita 2021.1 - some content have xref to this version
./build-preview-dev.bash \ --hide-edit-page-links true \ --force-production-navbar \ --type links-check \ --use-multi-repositories \ --component-with-branches bcd:3.6,4.0 \ --component-with-branches bonita:archives,2021.2,2022.1,2022.2,2023.1,2023.2 \ --component-with-branches central:1.0 \ --component-with-branches cloud:master \ --component-with-branches labs:master \ --component-with-branches test-toolkit:1.0,2.0 \ --local-sources
Output
Installation options