feat: full btc relay added #273
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
There was a problem hiding this comment.
I didn't pick apart the Summa code since I think this was mostly a copy-paste but please point out anything specific you changed or think would be worth a second look. I also think for next steps it could be good to integrate this code with BitcoinTx.sol and WitnessTx.sol (specifically validateWitnessProof) since I think that will let projects do some interesting things with Ordinals in the future.
src/relay/FullRelay.sol
Outdated
|
|
||
| /** | ||
| * @title Relay | ||
| * @author Summa (https://summa.one) |
|
|
||
| import {TestRelay} from "../../src/relay/FullRelayWithVerify.sol"; | ||
|
|
||
| import {stdJson} from "forge-std/StdJson.sol"; |
There was a problem hiding this comment.
Didn't know about this library before!
There was a problem hiding this comment.
Yeah, I was thinking it would have been nice in the bob-gateway project if we store all our
- env data like RPC node, chain id.... and
- deployed contract addresses
in Jsons for both prod tests.
I don't really like the current env variable approach there.
I can certainly integrate the full relay with those libraries, but just as a note a user has to decide in his project upfront what kind of relay he wants to use, as for example validateProof use different data for validation for the FullRelay compared to the LightRelay. How about doing this in a follow up PR? |
| * Forked from https://github.com/summa-tx/relays | ||
| * Changes made: | ||
| * 1. dependency changes | ||
| * - changed summa-tx/bitcoin-spv to keep-network/bitcoin-spv-sol |
There was a problem hiding this comment.
Changed to bob-collective/bitcoin-spv
Forked from https://github.com/summa-tx/relays
Changes made:
1.1 changed summa-tx/bitcoin-spv to keep-network/bitcoin-spv-sol
1.2 removed SafeMath
2.1 fixed some tests that were written incorrectly in the summa repo
2.2 ported Truffle javascript tests to Foundry solidity
2.3 new tests added
Closes #285