Merge pull request #335 from bob-collective/fix/add-refill

fix: add gas refill to fee
bob-collective · Sep 3, 2024 · 3d60993 · 3d60993
2 parents 5de1c6a + 1dbf737
commit 3d60993
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 13 deletions.
diff --git a/sdk/package-lock.json b/sdk/package-lock.json
diff --git a/sdk/package.json b/sdk/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@gobob/bob-sdk",
-  "version": "2.2.3",
+  "version": "2.2.4",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "scripts": {

diff --git a/sdk/src/gateway/client.ts b/sdk/src/gateway/client.ts
@@ -132,7 +132,7 @@ export class GatewayApiClient {
         const quote: GatewayQuote = await response.json();
         return {
             ...quote,
-            fee: Math.max(0, quote.fee - (params.gasRefill || 0)),
+            fee: quote.fee + (params.gasRefill || 0),
         };
     }
 

diff --git a/sdk/test/gateway.test.ts b/sdk/test/gateway.test.ts
@@ -34,7 +34,7 @@ describe("Gateway Tests", () => {
 
         nock(`${MAINNET_GATEWAY_BASE_URL}`)
             .get(`/quote/${SYMBOL_LOOKUP[ChainId.BOB]["tbtc"].address}?satoshis=1000`)
-            .times(6)
+            .times(5)
             .reply(200, mockQuote);
 
         assert.deepEqual(await gatewaySDK.getQuote({
@@ -67,14 +67,7 @@ describe("Gateway Tests", () => {
             toUserAddress: ZeroAddress,
             amount: 1000,
             gasRefill: 5,
-        }), { ...mockQuote, fee: 5 });
-        assert.deepEqual(await gatewaySDK.getQuote({
-            toChain: "BOB",
-            toToken: "tBTC",
-            toUserAddress: ZeroAddress,
-            amount: 1000,
-            gasRefill: 1000,
-        }), { ...mockQuote, fee: 0 });
+        }), { ...mockQuote, fee: 15 });
 
         // get the total available without amount
         nock(`${MAINNET_GATEWAY_BASE_URL}`)